Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Subpack Loading #4939

Open
letsgoawaydev opened this issue Aug 6, 2024 · 5 comments · May be fixed by #4978
Open

Resource Subpack Loading #4939

letsgoawaydev opened this issue Aug 6, 2024 · 5 comments · May be fixed by #4978
Labels
API The issue/feature request relates to the Geyser API Feature Request A feature request. Missing Implementation This has yet to be implemented.

Comments

@letsgoawaydev
Copy link
Contributor

What feature do you want to see added?

A way to resource pack subpacks using Geyser API

There should be a list of subpacks somewhere like what ResourcePackManifest has right now for modules, but with subpacks instead.

SessionLoadResourcePacksEvent would have an extra register(ResourcePack pack, Subpack pack) function.

Are there any alternatives?

Manually loading individual packs

@letsgoawaydev letsgoawaydev added the Feature Request A feature request. label Aug 6, 2024
@Konicai Konicai added the API The issue/feature request relates to the Geyser API label Aug 7, 2024
@Konicai Konicai changed the title [API] [F-Req] Resource Subpack Loading Resource Subpack Loading Aug 7, 2024
@Konicai Konicai added the Missing Implementation This has yet to be implemented. label Aug 7, 2024
@letsgoawaydev
Copy link
Contributor Author

yeah, the settings object in the manifest should also be exposed

@onebeastchris
Copy link
Member

onebeastchris commented Aug 11, 2024

The settings toggles aren't shown while a Bedrock client is connected to a server, so that is not something that we can implement. However, it seems to be possible to specify which subpack to load when sending the resource pack info entries to the client.

@letsgoawaydev
Copy link
Contributor Author

letsgoawaydev commented Aug 11, 2024

The settings aren't shown while a Bedrock client is connected to a server, so that is not something that we can implement. However, it seems to be possible to specify which subpack to load when sending the resource pack info entries to the client.

im saying that the settings object should be loaded and accessible in the api from the manifest.json because it has the list of all subpacks which can be helpful for optional pack loading extensions

@onebeastchris
Copy link
Member

onebeastchris commented Aug 11, 2024

Made a PR - opened as a draft as there are some things worth discussing.
As proposed by you; it does load the subpack entries in the manifest, and allows setting a subpack name to send to Bedrock players.

Futher, instead of adding another register method, i have opted to instead make the subpackName modifiable - in other words, here's how you'd currently use it:

And then you'd be able to register this pack in the SessionLoadResourcePacks event (or, in the future, the GeyserDefineResourcePacksEvent).

that's a pretty dumb way to do it, re-implementing a better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API The issue/feature request relates to the Geyser API Feature Request A feature request. Missing Implementation This has yet to be implemented.
Projects
None yet
3 participants