Skip to content

ensure donations to causes are included in givbacks calculations #70

@divine-comedian

Description

@divine-comedian

We should verify on the givbacks calculation service two things:

  • the queries required to get givbacks data didn't break from the changes we made to impact-graph
  • the queries include donation data to causes in their calculations

testing can be done here:
https://givback.develop.giveth.io/api-docs/

requires secure vpn credentials issued by devops to access.

setting parameters

  • dates: startdate/enddate can be set for any 2-3 week period within the last ~2 months, longer periods cause timeouts from getting too much data
  • giv price: fetch from coingecko -> https://www.coingecko.com/en/coins/giveth
  • round number: can be fetched using query on same page called current-round (can use current round -1 to get previous round)

all other parameters can be left as their default values

AC

these queries should be tested to ensure they do not throw an error when provided correct parameters:

  • calculate
  • eligible-donations
  • not-eligible-donations
  • purpleList-donations-to-verifiedProjects
  • calculate-updated

these queries should be tested to ensure cause donation data is included using eligible dates:

  • calculate
    • calculates givbacks amounts to distribute based on donation data
    • ensure donor addresses and donation value of eligible donations to causes are considered when calculations are made
    • can cross-reference data accuracy using eligible-donations
  • eligible-donations
    • donations made to causes with givbacks eligible tokens over min usd amount required
    • ensure eligible donations to causes appear here with correct data
  • not-eligible-donations
    • donations made with non-eligible givbacks tokens or givbacks tokens with donation value under min usd amount
    • ensure ineligible donations to causes appear here with correct data
  • purpleList-donations-to-verifiedProjects
    • address used as a project recipient address makes donation to verified project
    • ensure corresponding donations made to causes show up here with correct data
  • calculate-updated
    • simplified version of calculate that only requires round number
    • ensure donor addresses and donation value of eligible donations to causes are considered when calculations are made
    • can cross-reference data accuracy using eligible-donations

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions