Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GoodManWEN/cx_Oracle_async
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.3.1
Choose a base ref
...
head repository: GoodManWEN/cx_Oracle_async
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 6 commits
  • 4 files changed
  • 2 contributors

Commits on Oct 26, 2021

  1. Update cursors.py

    please add callproc function
    madridist20 authored Oct 26, 2021
    Copy the full SHA
    7146818 View commit details

Commits on Apr 15, 2022

  1. Update setup.py

    GoodManWEN authored Apr 15, 2022
    Copy the full SHA
    3a598c4 View commit details
  2. Merge pull request #17 from madridist20/patch-1

    Update cursors.py
    GoodManWEN authored Apr 15, 2022
    Copy the full SHA
    f488f35 View commit details
  3. Update setup.py

    GoodManWEN authored Apr 15, 2022
    Copy the full SHA
    fb3a537 View commit details
  4. Update python-publish.yml

    GoodManWEN authored Apr 15, 2022
    Copy the full SHA
    6b2e1ae View commit details

Commits on May 24, 2022

  1. Update README.md

    GoodManWEN authored May 24, 2022
    Copy the full SHA
    3d2f88a View commit details
Showing with 21 additions and 4 deletions.
  1. +5 −1 .github/workflows/python-publish.yml
  2. +3 −0 README.md
  3. +4 −1 cx_Oracle_async/cursors.py
  4. +9 −2 setup.py
6 changes: 5 additions & 1 deletion .github/workflows/python-publish.yml
Original file line number Diff line number Diff line change
@@ -17,9 +17,13 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: '3.7'
python-version: '3.8'
- name: Get latest release version number
id: get_version
uses: battila7/get-version-action@v2
- name: Install dependencies
run: |
echo ${{ steps.get_version.outputs.version-without-v }} >> tagname
python -m pip install --upgrade pip
pip install setuptools wheel twine requests beautifulsoup4 lxml
- name: Build and publish
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -11,6 +11,9 @@ A very simple asynchronous wrapper that allows you to get access to the Oracle d

Easy to use , buy may not the best practice for efficiency concern.

## About development release
In parallel with the main branch, we have worked on a development version based on [SQLAlchemy](https://github.com/sqlalchemy/sqlalchemy)'s thread pool management facilities, please refer to [Development notes](https://github.com/GoodManWEN/cx_Oracle_async/blob/dev/misc/Development_notes.md) for details.

## Requirements
- [cx_Oracle >= 8.1.0](https://github.com/oracle/python-cx_Oracle) (Take into consideration that author of cx_Oracle said he's trying to implement asyncio support , APIs maybe change in future version. Switch to 8.1.0 if there's something wrong makes it not gonna work.)
- [ThreadPoolExecutorPlus >= 0.2.0](https://github.com/GoodManWEN/ThreadPoolExecutorPlus)
5 changes: 4 additions & 1 deletion cx_Oracle_async/cursors.py
Original file line number Diff line number Diff line change
@@ -39,4 +39,7 @@ async def fetchall(self):
return await self._loop.run_in_executor(self._thread_pool , self._cursor.fetchall)

async def var(self, args):
return await self._loop.run_in_executor(self._thread_pool , self._cursor.var, args)
return await self._loop.run_in_executor(self._thread_pool , self._cursor.var, args)

async def callproc(self, *args , **kwargs):
return await self._loop.run_in_executor(self._thread_pool , self._cursor.callproc, *args , **kwargs)
11 changes: 9 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
@@ -28,11 +28,18 @@ def get_install_requires(filename):

html = BeautifulSoup(rget(url , headers).text ,'lxml')
description = html.find('meta' ,{'name':'description'}).get('content')
for kw in (' - GitHub', ' - GoodManWEN'):
if ' - GitHub' in description:
description = description[:description.index(' - GitHub')]
html = BeautifulSoup(rget(release , headers).text ,'lxml')
version = html.find('div',{'class':'release-header'}).find('a').text
logger.info(f"description: {description}")

#
with open('tagname','r',encoding='utf-8') as f:
version = f.read()
if ':' in version:
version = version[:version.index(':')].strip()
logger.info(f"description: {description}")
version = version.strip()
logger.info(f"version: {version}")

#