core(trace-engine-result): exclude failed source maps (#16412)

Author: connorjclark

build/build-cdt-lib.js

@@ -58,6 +58,12 @@ const modifications = [
       // eslint-disable-next-line max-len
       'Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.USE_SOURCE_MAP_SCOPES)': 'false',
       'Common.Base64.BASE64_CODES': 'BASE64_CODES',
+      '* Implements Source Map V3 model.': [
+        '* @param {string} compiledURL',
+        '* @param {string} sourceMappingURL',
+        '* @param {object} payload',
+        '* Implements Source Map V3 model.',
+      ].join('\n   '),
     },
     classesToRemove: [],
     methodsToRemove: [

core/computed/trace-engine-result.js

@@ -51,7 +51,7 @@ class TraceEngineResult {
       lanternSettings,
       async resolveSourceMap(params) {
         const sourceMap = SourceMaps.find(sm => sm.scriptId === params.scriptId);
-        if (!sourceMap) {
+        if (!sourceMap || !sourceMap.map) {
           return null;
         }
 

core/lib/cdt/generated/SourceMap.js

@@ -104,6 +104,9 @@ class SourceMap {
     #sourceInfoByURL = new Map();
     #scopesInfo = null;
     /**
+     * @param {string} compiledURL
+     * @param {string} sourceMappingURL
+     * @param {object} payload
      * Implements Source Map V3 model. See https://github.com/google/closure-compiler/wiki/Source-Maps
      * for format description.
      */