Skip to content

run/custom-metrics doesn't add SIGTERM/SIGINT handler for graceful shutdown #3554

@aabmass

Description

@aabmass

The Go program should add SIGTERM handler to shutdown the SDK. Right now it will just be ungracefully shutdown by Go's default SIGTERM handler, which means telemetry won't be flushed. See https://cloud.google.com/run/docs/samples/cloudrun-sigterm-handler

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: runIssues related to the Cloud Run API.priority: p2Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.stale: oldPull request is old and needs attention.triage meI really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions