From 377072d08b68455326bcfb6ec557812d7ddb4e77 Mon Sep 17 00:00:00 2001 From: Leandro Dorileo Date: Fri, 22 Nov 2024 14:08:26 -0800 Subject: [PATCH] network: fix nmcli check pattern (#472) Given the implementation of cliExists() we are ignoring one case by not checking the boolean return, if should assume nmcli doesn't exist if the boolean return is false and not the error as nil. --- google_guest_agent/network/manager/network_manager_linux.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google_guest_agent/network/manager/network_manager_linux.go b/google_guest_agent/network/manager/network_manager_linux.go index 56bd6c41..64b46c4b 100644 --- a/google_guest_agent/network/manager/network_manager_linux.go +++ b/google_guest_agent/network/manager/network_manager_linux.go @@ -143,8 +143,8 @@ func (n *networkManager) IsManaging(ctx context.Context, iface string) (bool, er // Check for existence of nmcli. Without nmcli, the agent cannot tell NetworkManager // to reload the configs for its connections. - _, err := cliExists("nmcli") - if err != nil { + exists, err := cliExists("nmcli") + if !exists { return false, err }