handle comm errors in script runner (#140)

GoogleCloudPlatform · Oct 19, 2021 · a1c10d1 · a1c10d1
1 parent 2b3561a
commit a1c10d1
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/google_metadata_script_runner/main.go b/google_metadata_script_runner/main.go
@@ -319,13 +319,20 @@ func runCmd(c *exec.Cmd, name string) error {
 	pw.Close()
 
 	in := bufio.NewScanner(pr)
-	for in.Scan() {
+	for {
+		if !in.Scan() {
+			if err := in.Err(); err != nil {
+				logger.Errorf("error while communicating with %q script: %v", name, err)
+			}
+			break
+		}
 		logger.Log(logger.LogEntry{
 			Message:   fmt.Sprintf("%s: %s", name, in.Text()),
 			CallDepth: 3,
 			Severity:  logger.Info,
 		})
 	}
+	pr.Close()
 
 	return c.Wait()
 }