Skip to content

Reservation Affinity for workbench instances #13328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

bcreddy-gcp
Copy link
Contributor

@bcreddy-gcp bcreddy-gcp commented Mar 11, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: added `reservation_affinity` field to `google_workbench_instance` resource.

@bcreddy-gcp bcreddy-gcp changed the title Wbi reservations Reservation Affinity for workbench instances Mar 11, 2025
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 471 insertions(+))
google-beta provider: Diff ( 4 files changed, 471 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 93 insertions(+))
Open in Cloud Shell: Diff ( 5 files changed, 153 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 21
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • workbench

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample
  • TestAccWorkbenchInstance_workbenchInstanceConfidentialComputeExample
  • TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceConfidentialComputeExample [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

@bcreddy-gcp, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions github-actions bot requested a review from BBBmau March 31, 2025 21:57
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample
  • TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample
  • TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 22
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample
  • TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample [Error message] [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link

github-actions bot commented Jun 3, 2025

@bcreddy-gcp, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 22
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • workbench
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample
  • TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceBasicGpuExample [Debug log]
TestAccWorkbenchInstance_workbenchInstanceFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@bcreddy-gcp bcreddy-gcp marked this pull request as draft June 9, 2025 18:49
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 277 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 277 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_updateMetadataKey

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_updateMetadataKey [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_updateMetadataKey

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkbenchInstance_updateMetadataKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 387 insertions(+))
google-beta provider: Diff ( 4 files changed, 387 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 62 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceEucExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceEucExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+))
google-beta provider: Diff ( 4 files changed, 263 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 52 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 28 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 24
Passed tests: 24
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • workbench
🟢 All tests passed!

View the build log

@bcreddy-gcp bcreddy-gcp marked this pull request as ready for review July 16, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants