workbench: Prevent setting server-managed metadata fields in config

[bcreddy-gcp]

yaqs/6794439800423186432

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: fixed metadata permadiff in `google_workbench_instance` resource.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: see go/terraform-auto-test-runs to set up automatic test runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[bcreddy-gcp]

Ref: hashicorp/terraform-provider-google#21585

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 13 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 13 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 13 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 13 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 15 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 15 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 23
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• workbench

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 15 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 4 files changed, 15 insertions(+), 1 deletion(-))
terraform-google-conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateMetadata
• TestAccWorkbenchInstance_updateMetadataKey

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_updateMetadata [Error message] [Debug log]
TestAccWorkbenchInstance_updateMetadataKey [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateMetadata
• TestAccWorkbenchInstance_updateMetadataKey

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 23
Passed tests: 21
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• workbench

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccWorkbenchInstance_updateMetadata
• TestAccWorkbenchInstance_updateMetadataKey

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 68 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 68 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 68 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 68 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+))

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• workbench

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccWorkbenchInstance_metadataValidation
  🟢 All tests passed!

View the build log

[modular-magician]

Tests analytics

Total tests: 24
Passed tests: 23
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

• workbench

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccWorkbenchInstance_metadataValidation
  🟢 All tests passed!

View the build log

[melinath]

This LGTM apart from updates needed for the 7.0 release (once that process starts.) reviewing to remove from my queue in the meantime.

[melinath]

Marking as changes requested to capture that it will need changes before being added to the 7.0 branch

[github-actions]

@bcreddy-gcp, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

[ScottSuarez]

converting to draft until the 7.0 branch has been cut