Skip to content

use location instead of region when populating location field when calling getCertificateAuthority #14536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

liuce-
Copy link
Contributor

@liuce- liuce- commented Jul 15, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

memorystore: use `location` instead of `region` when populating location field when calling getCertificateAuthority API

This PR is to fix issue hashicorp/terraform-provider-google#23543

Also update the test regions to be different than the provider level defaults to work around issue hashicorp/terraform-provider-google#23619

@liuce- liuce- changed the title Fix https://github.com/hashicorp/terraform-provider-google/issues/23543 for Memorystore instances and Memorystore Redis Cluster Fix #23543 for Memorystore instances and Memorystore Redis Cluster Jul 15, 2025
@liuce- liuce- changed the title Fix #23543 for Memorystore instances and Memorystore Redis Cluster use location instead of region when populating location field when calling getCertificateAuthority Jul 15, 2025
@github-actions github-actions bot requested a review from rileykarson July 15, 2025 23:09
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 131 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 131 insertions(+), 2 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 55
Passed tests: 53
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • memorystore
  • redis
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccMemorystoreInstance_memorystoreInstanceTlsEnabled
  • TestAccRedisCluster_redisClusterTlsEnabled

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 7 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 7 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 55
Passed tests: 53
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • memorystore
  • redis
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccMemorystoreInstance_memorystoreInstanceTlsEnabled
  • TestAccRedisCluster_redisClusterTlsEnabled

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceTlsEnabled [Error message] [Debug log]
TestAccRedisCluster_redisClusterTlsEnabled [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceTlsEnabled [Error message] [Debug log]
TestAccRedisCluster_redisClusterTlsEnabled [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 13 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 4 files changed, 13 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 55
Passed tests: 53
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • redis
  • memorystore
#### Action taken
Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccMemorystoreInstance_memorystoreInstanceTlsEnabled
  • TestAccRedisCluster_redisClusterTlsEnabled

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccMemorystoreInstance_memorystoreInstanceTlsEnabled [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccRedisCluster_redisClusterTlsEnabled [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 21
Passed tests: 21
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • memorystore
🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 21
Passed tests: 21
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • memorystore
🟢 All tests passed!

View the build log

Copy link

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants