Skip to content

WBI EUC #14548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

bcreddy-gcp
Copy link
Contributor

@bcreddy-gcp bcreddy-gcp commented Jul 16, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

workbench: added `enable_managed_euc` field to `google_workbench_instance` resource.

@github-actions github-actions bot requested a review from SirGitsalot July 16, 2025 21:28
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 87 insertions(+))
google-beta provider: Diff ( 2 files changed, 87 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceEucExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceEucExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 124 insertions(+))
google-beta provider: Diff ( 4 files changed, 124 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceEucExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceEucExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 147 insertions(+))
google-beta provider: Diff ( 4 files changed, 147 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceEucExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceEucExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@bcreddy-gcp bcreddy-gcp marked this pull request as draft July 16, 2025 23:44
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 153 insertions(+))
google-beta provider: Diff ( 4 files changed, 153 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 33 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceEucExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceEucExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 154 insertions(+))
google-beta provider: Diff ( 4 files changed, 154 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 34 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceEucExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceEucExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 154 insertions(+))
google-beta provider: Diff ( 4 files changed, 154 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 34 insertions(+))

@bcreddy-gcp
Copy link
Contributor Author

Can I get a review @madhusuraj

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 24
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • workbench
#### Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccWorkbenchInstance_workbenchInstanceEucExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccWorkbenchInstance_workbenchInstanceEucExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@bcreddy-gcp bcreddy-gcp marked this pull request as ready for review July 17, 2025 18:50
@github-actions github-actions bot requested a review from SirGitsalot July 17, 2025 18:51
@bcreddy-gcp bcreddy-gcp marked this pull request as draft July 17, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants