Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken spanner backup tests #893

Open
NivedhaSenthil opened this issue Dec 22, 2021 · 2 comments
Open

Fix broken spanner backup tests #893

NivedhaSenthil opened this issue Dec 22, 2021 · 2 comments
Labels
api: spanner Issues related to the Spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@NivedhaSenthil
Copy link
Member

The spanner broker tests take a lot time and hence becomes flaky when run from CI. Those tests are skipped to unblock other changes on presubmit.
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 22, 2021
NivedhaSenthil added a commit to NivedhaSenthil/ruby-docs-samples that referenced this issue Dec 22, 2021
@NivedhaSenthil
skip backup tests
2d20f76 
GoogleCloudPlatform#893
@NivedhaSenthil NivedhaSenthil mentioned this issue Dec 22, 2021
Merged
2 tasks
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Dec 23, 2021
@NivedhaSenthil NivedhaSenthil added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. api: spanner Issues related to the Spanner API. and removed triage me I really want to be triaged. labels Dec 23, 2021
@ansh0l
Copy link

ansh0l commented Jun 13, 2022

@NivedhaSenthil : Any update?

@NivedhaSenthil NivedhaSenthil added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 7, 2022
@NivedhaSenthil
Copy link
Member Author

The backup tests are still flaky, we may have to formulate a better approach to test backup as its a time consuming task.
Reducing priority for now as it's not a blocker.

@NivedhaSenthil NivedhaSenthil added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 30, 2023
@NivedhaSenthil NivedhaSenthil added type: cleanup An internal cleanup or hygiene concern. and removed samples Issues that are directly related to samples. labels Jul 11, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ansh0l @NivedhaSenthil @yoshi-automation