fix: no-push=true flags with test codes fixed

Author: rayshoo

pkg/skaffold/build/gcb/kaniko_test.go

@@ -469,11 +469,15 @@ func TestKanikoBuildSpec(t *testing.T) {
 	})
 
 	defaultExpectedArgs := []string{
-		"--destination", "gcr.io/nginx",
 		"--dockerfile", "Dockerfile",
 	}
 
 	for _, test := range tests {
+		expected := append([]string{}, defaultExpectedArgs...)
+		if !test.artifact.NoPush {
+			expected = append(expected, "--destination", "gcr.io/nginx")
+		}
+
 		testutil.Run(t, test.description, func(t *testutil.T) {
 			artifact := &latest.Artifact{
 				ImageName: "img1",
@@ -510,7 +514,7 @@ func TestKanikoBuildSpec(t *testing.T) {
 				},
 				Steps: []*cloudbuild.BuildStep{{
 					Name: "gcr.io/kaniko-project/executor",
-					Args: append(append(defaultExpectedArgs, imageArgs...), test.expectedArgs...),
+					Args: append(append(expected, imageArgs...), test.expectedArgs...),
 					Env:  test.expectedEnv,
 				}},
 				Options: &cloudbuild.BuildOptions{

pkg/skaffold/build/kaniko/args_test.go

@@ -438,7 +438,6 @@ func TestArgs(t *testing.T) {
 	}
 
 	defaultExpectedArgs := []string{
-		"--destination", "gcr.io/nginx",
 		"--dockerfile", "dir/Dockerfile",
 		"--context", fmt.Sprintf("dir://%s", DefaultEmptyDirMountPath),
 	}
@@ -450,7 +449,11 @@ func TestArgs(t *testing.T) {
 				t.Errorf("Args() error = %v, wantErr %v", err, test.wantErr)
 				return
 			}
-			t.CheckDeepEqual(got, append(defaultExpectedArgs, test.expectedArgs...))
+			if test.artifact.NoPush {
+				t.CheckDeepEqual(got, append(defaultExpectedArgs, test.expectedArgs...))
+			} else {
+				t.CheckDeepEqual(got, append(defaultExpectedArgs, "--destination", "gcr.io/nginx", test.expectedArgs...))
+			}
 		})
 	}
 }