feat(bin): Add graceful shutdown for helm command #9520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idsulik
force-pushed
the
helm-graceful-shutdown
branch
from
88220e6
to
11401bb
Compare
Signed-off-by: Suleiman Dibirov <[email protected]>
idsulik
force-pushed
the
helm-graceful-shutdown
branch
from
11401bb
to
a09c6eb
Compare
|
Hi @plumpy, please check the PR, because it's very important, especially with these changes #9451, because if a user executes parallel package installation and interrupts it, all the packages will remain in pending state, because skaffold kills the helm command execution on context cancellation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added graceful shutdown for helm command
the CommandContext kills the process when we cancel the context
it leads to an inconsistent state in helm charts, the helm left chart in "pending-install" state.
How to reproduce the issue:
Ctrl/CMD + Chelm status {releaseName}, the status will be "pending-install"helm another operation (install/upgrade/rollback) is in progressThis fix gives the helm 15 seconds to rollback(if you pass
--atomic) and/or save the actual(failed) state of the release