-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Open
Description
skaffold dev -v debug --detect-minikube=false 2>&1 | grep minikube
msg="Running command: [minikube version --output=json]" subtask=-1 task=DevLoop
msg="Command output: [{\"commit\":\"65318f4cfff9c12cc87ec9eb8f4cdd57b25047f3\",\"minikubeVersion\":\"v1.37.0\"}\n]" subtask=-1 task=DevLoop
msg="Minikube cluster detected: cluster certificate for context \"test\" found inside the minikube directory" subtask=-1 task=DevLoop
msg="Running command: [/home/linuxbrew/.linuxbrew/bin/minikube docker-env --shell none -p test --user=skaffold]" subtask=-1 task=DevLoop
msg="Command output: [SSH_AUTH_SOCK=/tmp/ssh-Zj6AhgVo2905/agent.2216632\nSSH_AGENT_PID=2216633\nDOCKER_HOST=ssh://[email protected]:32773\nMINIKUBE_ACTIVE_DOCKERD=test\n], stderr: ! Using the docker-env command with the containerd runtime is a highly experimental feature, please provide feedback or contribute to make it better\nIdentity added: /home/denk/.minikube/machines/test/id_rsa (/home/denk/.minikube/machines/test/id_rsa)\n" subtask=-1 task=DevLoop
msg="Using minikube docker daemon at ssh://[email protected]:32773" subtask=-1 task=DevLoop
It's just that the detect-minikube
flag is not checked here
skaffold/pkg/skaffold/docker/client.go
Lines 84 to 92 in 95fb592
func newAPIClient(ctx context.Context, kubeContext string, minikubeProfile string) ([]string, client.CommonAPIClient, error) { | |
if minikubeProfile != "" { // skip validation if explicitly specifying minikubeProfile. | |
return newMinikubeAPIClient(ctx, minikubeProfile) | |
} | |
if cluster.GetClient().IsMinikube(ctx, kubeContext) { | |
return newMinikubeAPIClient(ctx, kubeContext) | |
} | |
return newEnvAPIClient() | |
} |
How does this happen here
skaffold/pkg/skaffold/config/util.go
Lines 252 to 253 in 95fb592
case opts.DetectMinikube: | |
local = cluster.GetClient().IsMinikube(ctx, kubeContext) |
Based on common sense,
The current behavior is obviously wrong
I don't understand why it hasn't been fixed yet.
someone just started using kind
overrides minikube in $PATH
other try using rename hack
which should not work for 5 years as
because it is successfully detecting by the certificate.
Metadata
Metadata
Assignees
Labels
No labels