Fix/multiply alpha for table color#3549
Open
garvittsingla wants to merge 3 commits intoGraphiteEditor:masterfrom
Open
Fix/multiply alpha for table color#3549garvittsingla wants to merge 3 commits intoGraphiteEditor:masterfrom
garvittsingla wants to merge 3 commits intoGraphiteEditor:masterfrom
Conversation
0HyperCube
reviewed
Dec 31, 2025
Contributor
0HyperCube
left a comment
There was a problem hiding this comment.
This is an approach to fixing the issue.
I'm not sure if it is advantageous to have both the alpha_blending.opacity and the element.opacity?
Author
@0HyperCube It makes sense, I just don't removed the alpha blending opacity, thought to have a review first Should i remove it? |
Author
|
@0HyperCube Should I delete it?? |
Contributor
|
I do not mind. Do whatever you prefer. |
124235a to
a42cad8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3205
The main problem was in
MultiplyAlpha for Table<Color>, where only the alpha_blending.opacity was changing but not the color opacity as mentioned itself in the issueI changed the color alpha itself with the function
multiplied_alphaunder theAlphaMuttrait.My fix is this:
Faulty behavior
Change in opacity node before the fill value does not changes anything. The opacity is always full
Corrected behaviour

Now changing the opacity changes the color opacity