Add combined parameter to box_warp function #3553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Keavon could you please approve the workflows when ready? If everything looks good, feel free to merge. Thanks! |
Added logic to compute combined bounding box for vectors.
mathurojus
commented
Dec 31, 2025
|
|
||
| #[node_macro::node(category("Vector: Modifier"), path(core_types::vector))] | ||
| async fn box_warp(_: impl Ctx, content: Table<Vector>, #[expose] rectangle: Table<Vector>) -> Table<Vector> { | ||
| async fn box_warp(_: impl Ctx, content: Table<Vector>, #[expose] rectangle: Table<Vector>, #[expose] combined: bool) -> Table<Vector> { |
Author
There was a problem hiding this comment.
@0HyperCube
Added the implementation for the combined parameter. When combined=true, the function now computes a unified bounding box for all vectors and applies the warp uniformly. When combined=false, it uses individual bounding boxes (original behavior).
Does this approach look correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
combinedparameter to control whether the box warp treats all subpaths as a single object (when true) or warps them individually (when false).Fixes #3551