Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject VITE_CLOUD_URL at runtime #158

Open
sunng87 opened this issue Mar 6, 2023 · 1 comment
Open

Inject VITE_CLOUD_URL at runtime #158

sunng87 opened this issue Mar 6, 2023 · 1 comment
Assignees

Comments

@sunng87
Copy link
Member

sunng87 commented Mar 6, 2023

          We need to seek a further solution to inject `VITE_CLOUD_URL` at runtime so we can reuse same image across different environments. Let me create an issue for this.

Originally posted by @sunng87 in #156 (review)

@ZonaHex ZonaHex self-assigned this Mar 6, 2023
@ZonaHex
Copy link
Collaborator

ZonaHex commented May 12, 2023

I don't think we could use the same image for dev and staging. Because the variable is determined during build-time.
We could edit the action YML and make sure the commit sha for the staging image is (one of) the latest sha for the dev image (already tested).
Perhaps add a new file to store the latest sha list. The commit sha for the staging image should only be selected from the sha list, not be text editable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants