Remove default setting of CMAKE_DEBUG_POSTFIX (#5600)

Author: MarDiehl

config/HDFMacros.cmake

@@ -472,15 +472,6 @@ macro (HDF_DIR_PATHS package_prefix)
     set (CMAKE_PREFIX_PATH ${ADDITIONAL_CMAKE_PREFIX_PATH} ${CMAKE_PREFIX_PATH})
   endif ()
 
-  #set the default debug suffix for all library targets
-  if(NOT CMAKE_DEBUG_POSTFIX)
-    if (WIN32)
-      set (CMAKE_DEBUG_POSTFIX "_D")
-    else ()
-      set (CMAKE_DEBUG_POSTFIX "_debug")
-    endif ()
-  endif ()
-
   SET_HDF_BUILD_TYPE()
 
   SET_HDF_OUTPUT_DIRS(${package_prefix})

config/cmake/cacheinit.cmake

@@ -40,6 +40,15 @@ set (HDF_TEST_EXPRESS "2" CACHE STRING "Control testing framework (0-3)" FORCE)
 
 set (HDF5_MINGW_STATIC_GCC_LIBS ON CACHE BOOL "Statically link libgcc/libstdc++" FORCE)
 
+#set the default debug suffix for all library targets
+if (NOT CMAKE_DEBUG_POSTFIX)
+  if (WIN32)
+    set (CMAKE_DEBUG_POSTFIX "_D")
+  else ()
+    set (CMAKE_DEBUG_POSTFIX "_debug")
+  endif ()
+endif ()
+
 set (HDF5_ALLOW_EXTERNAL_SUPPORT "TGZ" CACHE STRING "Allow External Library Building (NO GIT TGZ)" FORCE)
 set_property (CACHE HDF5_ALLOW_EXTERNAL_SUPPORT PROPERTY STRINGS NO GIT TGZ)
 

release_docs/RELEASE.txt

@@ -796,6 +796,12 @@ Bug Fixes since HDF5-2.0.0 release
 
     Configuration
     -------------
+    - Remove default setting of CMAKE_DEBUG_POSTFIX
+
+      Move the default setting of CMAKE_DEBUG_POSTFIX to the cacheinit.cmake file
+      usually used by testing. If CMAKE_DEBUG_POSTFIX is not set with a -D option
+      then CMAKE_DEBUG_POSTFIX will be the default provided by CMake itself.
+    
     - The relative rpaths ($ORIGIN / @loader_path) are appended to the CMAKE_INSTALL_RPATH
 
       The RPATH settings were removed by a pull-request #5271, but the settings are needed