Crystallography Refactored (#701)

* Reformat utils

* Remove unused _convert_angles function

* Remove check for numba install

* Clean up unused variables, add typing

* Remove unused _coo_build_window function

* Add type hints to function defs

* Remove unnecessary variables / passes

* Provide deprecation warnings to the user.

* Tuple -> tuple

* List -> list, Dict -> dict

* Change deprecated to accept str instead of func

* Remove unnecessary "save" func from etaOmeMaps

* Add deprecation date

* Format with Black

* Clean up name mangling, bad returns

* Move to f-strings

* Clean up properties

* Delete some unused functions

* Remove makeNew function, which is not a useful method

* Some docstrings, committing to swtich branches

* Some docstrings written, properties now using annotations

* Typing and cleanup

* Remove unused functions/args

* Added docstrings

* Update crystallography.py

* Push before pull

* Crystallography done

* PEP8

* Union instead of |

* Copy plane data

---------

Co-authored-by: Zack Singer <[email protected]>

Author: kevindlewis23

hexrd/findorientations.py

@@ -88,7 +88,7 @@ def generate_orientation_fibers(cfg, eta_ome):
     pd = eta_ome.planeData
     tTh = pd.getTTh()
     bMat = pd.latVecOps['B']
-    csym = pd.getLaueGroup()
+    csym = pd.laueGroup
 
     # !!! changed recently where iHKLList are now master hklIDs
     pd_hkl_ids = eta_ome.iHKLList[seed_hkl_ids]
@@ -885,8 +885,8 @@ def find_orientations(cfg,
     logger.info("\tmean reflections per grain: %d", mean_rpg)
     logger.info("\tneighborhood size: %d", min_samples)
 
-    qbar, _ = run_cluster(
-        completeness, qfib, plane_data.getQSym(), cfg,
+    qbar, cl = run_cluster(
+        completeness, qfib, plane_data.q_sym, cfg,
         min_samples=min_samples,
         compl_thresh=compl_thresh,
         radius=cl_radius)

hexrd/instrument/detector.py

@@ -1131,14 +1131,7 @@ def make_powder_rings(
 
         # in case you want to give it tth angles directly
         if isinstance(pd, PlaneData):
-            # Okay, we have a PlaneData object
-            try:
-                pd = pd.makeNew()  # make a copy to munge
-            except TypeError:
-                # !!! have some other object here,
-                #     likely a dummy plane data object of sorts
-                raise
-
+            pd = PlaneData(None, pd)
             if delta_tth is not None:
                 pd.tThWidth = np.radians(delta_tth)
             else: