Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially Unused Function plot_ori_map #657

Closed
ZackAttack614 opened this issue Jun 28, 2024 · 2 comments
Closed

Potentially Unused Function plot_ori_map #657

ZackAttack614 opened this issue Jun 28, 2024 · 2 comments

Comments

@ZackAttack614
Copy link
Collaborator

The variable roi is undefined in this function. This leads me to believe that the function has never been used, and probably won't be.

Consider deletion.
@ZackAttack614 ZackAttack614 assigned psavery and unassigned psavery Jun 28, 2024
@psavery
Copy link
Collaborator

psavery commented Jul 1, 2024

They probably meant rotations instead of rot. Since this is in grainmap, this comment applies as well.

@psavery
Copy link
Collaborator

psavery commented Aug 7, 2024

I think this was fixed in #631.

@psavery psavery closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZackAttack614 @psavery