Use gray background, white text for disabled value

Signed-off-by: Patrick Avery <[email protected]>

Author: psavery

hexrdgui/calibration/calibration_dialog.py

@@ -500,6 +500,9 @@ def update_disabled_editor_paths(self):
             # The value is uneditable
             uneditable_paths.append(self.tardis_ip4_y_path + (value_idx,))
 
+        # A tree view update is necessary after changing the disabled editors
+        self.update_tree_view()
+
     @property
     def has_tardis_constraints(self):
         return self.engineering_constraints == 'TARDIS'

hexrdgui/calibration/tree_item_models.py

@@ -52,6 +52,27 @@ def set_config_val(self, path, value):
 
         setattr(param, attribute, value)
 
+    def data(self, index, role):
+        if (
+            role in (Qt.BackgroundRole, Qt.ForegroundRole) and
+            index.column() in (self.VALUE_IDX, self.VARY_IDX) and
+            self.has_uneditable_paths
+        ):
+            # Check if this value is uneditable. If so, gray it out.
+            item = self.get_item(index)
+            path = tuple(self.path_to_item(item) + [self.VALUE_IDX])
+            if path in self.uneditable_paths:
+                color = 'gray'
+                if (
+                    index.column() == self.VALUE_IDX and
+                    role == Qt.ForegroundRole
+                ):
+                    color = 'white'
+
+                return QColor(color)
+
+        return super().data(index, role)
+
 
 class DefaultCalibrationTreeItemModel(CalibrationTreeItemModel):
     """This model uses minimum/maximum for the boundary constraints"""
@@ -86,16 +107,6 @@ def data(self, index, role):
 
                     if abs(item.data(pair[0]) - item.data(pair[1])) < atol:
                         return QColor('red')
-        if (
-            role == Qt.ForegroundRole and
-            index.column() == self.VALUE_IDX and
-            self.has_uneditable_paths
-        ):
-            # Check if this value is uneditable. If so, gray it out.
-            item = self.get_item(index)
-            path = tuple(self.path_to_item(item) + [index.column()])
-            if path in self.uneditable_paths:
-                return QColor('gray')
 
         return super().data(index, role)
 

hexrdgui/resources/ui/calibration_dialog.ui

@@ -50,7 +50,7 @@
       <item row="3" column="1">
        <widget class="QComboBox" name="engineering_constraints">
         <property name="toolTip">
-         <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Add engineering constraints for certain instrument types. This may add extra parameters to the table.&lt;/p&gt;&lt;p&gt;&lt;br/&gt;&lt;/p&gt;&lt;p&gt;For example, for TARDIS, the distance between IMAGE-PLATE-2 and IMAGE-PLATE-4 must be within a certain range. If TARDIS is selected, a new parameter is added with default values for this distance.&lt;/p&gt;&lt;p&gt;&lt;br/&gt;&lt;/p&gt;&lt;p&gt;If the instrument type can be guessed, it will be selected automatically when the dialog first appears. For example, TARDIS is automatically selected if any of the detector names are IMAGE-PLATE-2, IMAGE-PLATE-3, or IMAGE-PLATE-4.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
+         <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;Add engineering constraints for certain instrument types. This may add extra parameters to the table.&lt;/p&gt;&lt;p&gt;&lt;br/&gt;&lt;/p&gt;&lt;p&gt;For example, for TARDIS, the distance between IMAGE-PLATE-2 and IMAGE-PLATE-4 must be within a certain range. If TARDIS is selected, a new parameter is added with default values for this distance, and the y value of IMAGE-PLATE-4 is disabled for editing/refinement since it is computed from the distance instead.&lt;/p&gt;&lt;p&gt;&lt;br/&gt;&lt;/p&gt;&lt;p&gt;If the instrument type can be guessed, it will be selected automatically when the dialog first appears. For example, TARDIS is automatically selected if IMAGE-PLATE-2 and IMAGE-PLATE-4 are present.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
         </property>
         <item>
          <property name="text">