Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails are Black #64

Open
omarojo opened this issue Aug 1, 2020 · 3 comments
Open

Thumbnails are Black #64

omarojo opened this issue Aug 1, 2020 · 3 comments

Comments

@omarojo
Copy link

omarojo commented Aug 1, 2020

Hi and thank you for building this library. AVFoundation is soo hard.

So I have a VideoComposition that has 5 videos stitched together one after the other.
And then played in a AVPlayer, when I export into a .mp4 file all videos get stiched together well (no black frames).
In other words... Im not playing a .mp4 file but a AVComposition. Im assigning a AVAsset that is generated from a composition of several mp4 files.

But the problem is when I try to load the playerItem into PryntTimmerView. It loads black frames on every pair index.
For example the first clip is fine, but second and fourth clips show black frames as thumbnails. always pairs. If I keep adding clips to the composition, it's always the pair index that will show black frames.

I read that maybe using requestedTimeToleranceAfter may help.

    assetImgGenerate.requestedTimeToleranceAfter = .zero
    assetImgGenerate.requestedTimeToleranceBefore = .zero

Video Attached:
https://youtu.be/mYFcBLS1DQE

@omarojo
Copy link
Author

omarojo commented Aug 4, 2020

I think I figure it out.
I had to modify your library to accept having custom ImageGenerator.

@Monkey-X-Byte
Copy link

I also found this problem, and even with these two properties, the scrolling thumbnails overlapped

@HHK1
Copy link
Owner

HHK1 commented Sep 18, 2020

Hi @omarojo, do you have a repo with an example ? If you have a fix you can open a PR, contributions are welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants