Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApnsConfig.Builder中addPayloadAps和addPayload内容相同。 #21

Open
superinkfish opened this issue Sep 27, 2023 · 0 comments
Open

Comments

@superinkfish
Copy link

原代码:

        public Builder addPayloadAps(Aps aps) {
            this.aps = aps;
            return this;
        }

        public Builder addPayload(Aps aps) {
            this.aps = aps;
            return this;
        }

两个方法内容相同。ApnsConfig.Builder中缺乏setAps()方法,addPayloadAps()和addPayload()方法容易让人觉得和参数payloadAps和payload相关,容易有误解。建议改为:

        public Builder setAps(Aps aps) {
            this.aps = aps;
            return this;
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant