Skill Bottom Dialog added in 4.7.7 doubles required taps to use skills

[mwberry]

Describe the bug

Prior to the 4.7.7 release, healing a party might take 3-4 taps of the Blessing skill. The taps could be made in rapid succession because it was fairly straightforward to see how much damage the party accumulated on the Party tab, then heal them a proportional amount.

Post the 4.7.7 update, there is a new Skill Bottom Dialog which appears when you tap a skill and requires a second tap to confirm you want to use the skill. This doubles the number of taps required to use a skill, but also slows the process down as you must tap two buttons in different locations in an alternating fashion instead of rapidly tapping a single button.

To Reproduce

Previous steps

1. Go to Party tab, observe level of damage
2. Go to skills tab
3. Tap Blessing skill 4 times (for example) rapidly

New steps

1. Go to Party tab, observe level of damage
2. Go to skills tab
3. Tap Blessing
4. Wait for bottom dialog
5. Tap to confirm to use Blessing
6. Tap Blessing
7. Wait for bottom dialog
8. Tap to confirm to use Blessing
9. Tap Blessing
10. Wait for bottom dialog
11. Tap to confirm to use Blessing
12. Tap Blessing
13. Wait for bottom dialog
14. Tap to confirm to use Blessing

Expected behavior

I know Habitica isn't the sort of game to speed run, but this dialog represents a speed bump that doesn't add any additional value. The dialog repeats the exact text already displayed on the Skills tab. I've never accidentally used a skill before, and one accidental skill usage isn't a big feal in terms of game play, so I don't see the value in a confirmation dialog.

Screenshots

Smartphone (please complete the following information):

• Device: Any
• OS: Android
• App Version: 4.7.7
• Habitica Username: Any

Additional context
Add any other context about the problem here.

[mwberry]

After digging through old issues, I found the issue that prompted this change. Importantly, it captures what the motivation for the change was. (Neither were in the commit message).

#2081

The stated reason for adding the new dialog was for languages whose translations would not fit in the provided space. The additional tap was called out at the time.

Maybe there's an alternative that can both accommodate more space for description text, but also doesn't introduce friction when using a skill? Presumably, users only need to read the skill's full description occasionally (new users may need to more frequently at first, but regular users likely wouldn't need to unless they switch class).

Having bimodal behavior based on the age of the account, age in class, or number of times the skill was used all seem like added complexity, without totally solving the need.

Could the dialog with the full-length description be relegated to a context menu, so it is only shown when requested?

[seeb0h]

I reported the same bug in the bad repo (sorry for that).
Your proposal with two way of interacting (tap left or right) is clever and would be fine.

[saraolson]

@mwberry @seeb0h
Thanks for your feedback! The split tap areas is definitely an option we can look into.

However, another purpose of the bottom sheet was to provide another layer of confirmation before spending mana, similar to buy modals. We always have to balance people that want to do things fast with people who may tap a little too fast and don't realize resources are going to get spent right away. We chose to move forward with the the extra step to prevent the more destructive of the two cases.

With that in mind, we're still open to feedback if it ends up being more of a hindrance than help :) The next bugfix build this change would be included in wont be out for a few weeks due to the way release schedules worked out, so i'll leave this thread up for any further thoughts/voices of support in the meantime.