[Feature Request] Avoid duplicate wallpaper in random mode

[contact-maximux]

Confirmation

• I have read the Code of Conduct
• I have searched the existing issues

Feature Description

add feature to not use wallpaper of last #N duration

Describe the Solution

I have 6000 wallpaper in one folder. I want app must not pick any wallpaper used earlier.

Whenever you do. May be achieved like this

Ask permission to rename all wallpapers name
Now before applying any wallpaper just rename it to some pattern
Now for next wallpaper button: search image not having above pattern
When all image renamed to that pattern, that means all wallpaper has been used.
Now you can remove that pattern string from all images and notify user that "Wallpaper exhausted. NOW WALLPAPER WILL BE REPEATED"
Problem solved without Database

Describe Alternatives

No response

Additional Context

No response

Sufficiency Confirmation

• I have provided all the information requested above and deemed sufficient for the developer to address the issue

[Hamza417]

Then why not use Pick in Linear Order toggle? It was added to solve a similar problem #50

[contact-maximux]

Thank for quick reply. I was not sure if it handle continuously increasing files in same folder. file are added random name. Like few file can be added on top between or last. Like newly added filename may start with a, g, j, z, 0

…

On Tue, 19 Nov, 2024, 23:37 Hamza Rizwan, ***@***.***> wrote: Then why not use *Pick in Linear Order* toggle? It was added to solve a similar problem #50 <#50> — Reply to this email directly, view it on GitHub <#115 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BI47AR3UK3WM23B2LOOEQST2BN45ZAVCNFSM6AAAAABSCWJE22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWGQYDQOJUGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Hamza417]

The linear picker only remembers the position of the last set wallpaper meaning it starts from the beginning and one by one sets the next wallpaper until the last and then starts again and in the auto wallpaper the list is sorted by date of the file and doesn't adhere to the configurations you are using in the app. So, there is a very low chance your wallpaper will repeat unless the list if modified or its state has changed like few new wallpapers are added or deleted then the position may set arbitrary or repeating wallpapers until its last correct location is reached.

[contact-maximux]

Thanks for attentional reply. App is already at sweet spot. I love it. Though can be overdo or little impactful
Suggestion:
Example: No repeat wallpaper till 10 days until there are fresh images in folder.
May there will be a container which hold the name of image applied and avoid using any image as wallpaper whose name exist in container. Reset that container after 10 days or when no images left used. Sorry I am not technical to elaborate that deeply.

[Hamza417]

May there will be a container which hold the name of image applied and avoid using any image as wallpaper whose name exist in container. Reset that container after 10 days or when no images left used. Sorry I am not technical to elaborate that deeply.

I thought about adding a persistent memory for auto wallpaper but deemed it unnecessary. I think something like this can be added, a separate database would do.

[frfeed123]

Any work on it yet?

[Hamza417]

Any work on it yet?

Not yet, this particular issue requires a little bit of testing and thought processing since there are a lot of variables involved and all of them need to work correctly. And, recently, #122 and #98 will need to be addressed as well. Any updates will be posted here by default once I begin working on the issue. I am just a bit occupied lately with academics and learning.

[contact-maximux]

Whenever you do. May be achieved like this

• Ask permission to rename all wallpapers name
• Now before applying any wallpaper just rename it to some pattern
• Now for next wallpaper button: search image not having above pattern
• When all image renamed to that pattern, that means all wallpaper has been used.
• Now you can remove that pattern string from all images and notify user that "Wallpaper exhausted. NOW WALLPAPER WILL BE REPEATED"

Problem solved without Database
Problem: I have 1000+ wallpaper in folder but each time I saw only few wallpapers. I hate it.
@Hamza417 @frfeed123

[Hamza417]

app-prod-release.zip

Test the app file and let me know what didn't work.

[ZornHadNoChoice]

• Ask permission to rename all wallpapers name

I personally wouldn't like my wallpaper names to be changed, so this should be optional if it's implemented.

[Hamza417]

• Ask permission to rename all wallpapers name

I personally wouldn't like my wallpaper names to be changed, so this should be optional if it's implemented.

No, I created a database and fetched the difference of the wallpapers. It should correspond to this diagram. The A is the wallpaper we will use and B is wallpaper that has been already used. It runs until A is exhausted, then B is cleaned up and repeat.

[ZornHadNoChoice]

Nice! I think I can benefit from this feature too since I have 2300 wallpapers that would take forever to show up all if they repeated.

The A is the wallpaper we will use

I hope you meant A-B. Did not expect a Ven diagram here 😅.

[ZornHadNoChoice]

Test the app file and let me know what didn't work.

I couldn't find an option to enable this new feature. If there isn't one, please add it!

[Hamza417]

Test the app file and let me know what didn't work.

I couldn't find an option to enable this new feature. If there isn't one, please add it!

I decided to make it the default behavior, so no toggle needed. It will just work.

[ZornHadNoChoice]

I decided to make it the default behavior, so no toggle needed. It will just work.

But what if I stopped liking this feature, an option to disable it would be appreciated.

[contact-maximux]

should

I agree this. But it can be no change wallpaper name, like
river.jpg => river_peristyle_timestamp.jpg

When done. name back to original. I don't think adding a suffix in any file will effect any of existing setup.

[Hamza417]

A database approach is the most suitable one here, all files are already assigned proper IDs to them, I only needed to create a different set for used wallpapers and then compare the list each time a wallpaper operation occurs and most importantly it's really fast with almost zero load on the system unlike renaming a file which poses a risk of significant I/O load for huge number of files.

[contact-maximux]

A database approach is the most suitable one here, all files are already assigned proper IDs to them, I only needed to create a different set for used wallpapers and then compare the list each time a wallpaper operation occurs and most importantly it's really fast with almost zero load on the system unlike renaming a file which poses a risk of significant I/O load for huge number of files.

This suits well. But require more work. Alternate like having filename in .file in same folder as added one.

[contact-maximux]

app-prod-release.zip

Test the app file and let me know what didn't work.

Each time wallpaper change(Auto or clicking NEXT WALLPAPER) error comes. Tried both method.

• API wallpaper
• Next wallpaper

I set delay one minute and now after every minute it s giving error notification.

java.util.NoSuchElementException: Collection is empty. at kotlin.collections.CollectionsKt.random(SourceFile:31) at app.simple.peri.abstraction.AbstractAutoWallpaperService$getRandomWallpaperFromDatabase$2.invokeSuspend(SourceFile:168) at app.simple.peri.abstraction.AbstractAutoWallpaperService$getRandomWallpaperFromDatabase$2.invoke(SourceFile:13) at kotlin.time.DurationKt.startUndispatchedOrReturn(SourceFile:5) at kotlinx.coroutines.JobKt.withContext(SourceFile:74) at app.simple.peri.services.AutoWallpaperService.access$getLockScreenWallpaper(SourceFile:335) at app.simple.peri.abstraction.AbstractComposeAutoWallpaperService$setComposeWallpaper$1.invokeSuspend(SourceFile:348) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:9) at kotlinx.coroutines.DispatchedTask.run(SourceFile:113) at androidx.core.app.ActivityRecreator$1.run(SourceFile:12) at kotlinx.coroutines.scheduling.TaskImpl.run(SourceFile:3) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(SourceFile:96)

[Hamza417]

app-prod-release.zip

This should fix it

[ZornHadNoChoice]

It seems that setting the wallpaper manually works, but using the Next Wallpaper button doesn't. Then I tried Live Auto Wallpaper button and set the wallpaper to home, and I got this notification:

Error getting wallpaper by folder: java.util.NoSuchElementException: Collection is empty.

[ZornHadNoChoice]

Also, I keep getting "an instance is already running, please wait" and "changing wallpaper, please wait" but nothing changes. And I got this now:

[Hamza417]

app-prod-release.zip

I mistakenly used the same instance of the wallpaper database, this should fix it. Make sure your wallpaper database is valid before hitting the next wallpaper button.

[contact-maximux]

app-prod-release.zip

I mistakenly used the same instance of the wallpaper database, this should fix it. Make sure your wallpaper database is valid before hitting the next wallpaper button.

Fresh install, fresh wallpaper folder added. No error observed. checking randomness and duplicity. You did magic. Wallpaper changing taken time is extremely fast.

WhatsApp.Video.2025-02-19.at.15.54.43.mp4

[ZornHadNoChoice]

@Hamza417 Just a question: does the "Recreate Database" option reset the list of wallpapers already used?

[Hamza417]

It should only affect the folders' database. The wallpaper memory database gets cleared when the list is exhausted.