Skip to content
This repository was archived by the owner on Mar 25, 2020. It is now read-only.

Wrong documentation on hover #13

Open
HandOfGod94 opened this issue Nov 3, 2018 · 1 comment
Open

Wrong documentation on hover #13

HandOfGod94 opened this issue Nov 3, 2018 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@HandOfGod94
Copy link
Owner

HandOfGod94 commented Nov 3, 2018

Following issues needs to be addressed regarding documentation:

  • Since documentation is searched with selectSingleNode it will display wrong documentation if the tag remains same.
  • namespace specific documentation. If elements belongs to different namespace, it should search documentation based on the namespace. Currently, it searches all the xsds files specified in schemaLocation.

Steps to reproduce:

  • Open any of the complex pom.xml, such as this projects itself, in any editor supporting LSP, preferably VSCode.
  • Hover over artifactId in dependency and parent pom itself, both displays same documentation.
@HandOfGod94 HandOfGod94 added the bug Something isn't working label Nov 3, 2018
@HandOfGod94 HandOfGod94 added this to the 1.0.0-alpha milestone Nov 3, 2018
@HandOfGod94 HandOfGod94 changed the title Bug: Wrong documentation on hover Wrong documentation on hover Nov 10, 2018
HandOfGod94 pushed a commit that referenced this issue Nov 10, 2018
Uses PositionalHandler to list all the possible elements
or attributes should be at current position. It matches
possibilities with word being hovered. This eliminates
the documentation ambiguity which is currently observed
in bug #13.

Relates to #13
HandOfGod94 pushed a commit that referenced this issue Nov 10, 2018
Uses PositionalHandler to list all the possible elements
or attributes should be at current position. It matches
possibilities with word being hovered. This eliminates
the documentation ambiguity which is currently observed
in bug #13.

Relates to #13
HandOfGod94 pushed a commit that referenced this issue Nov 15, 2018
Uses PositionalHandler to list all the possible elements
or attributes should be at current position. It matches
possibilities with word being hovered. This eliminates
the documentation ambiguity which is currently observed
in bug #13.

Relates to #13
HandOfGod94 pushed a commit that referenced this issue Nov 16, 2018
Uses PositionalHandler to list all the possible elements
or attributes should be at current position. It matches
possibilities with word being hovered. This eliminates
the documentation ambiguity which is currently observed
in bug #13.

Relates to #13
@HandOfGod94
Copy link
Owner Author

HandOfGod94 commented Dec 29, 2018

The implementation is now completely different than what was described earlier. Still the bug remains, because of the nature of XML.
Some XSD authors wants documentation to be alongside the xs:element itself, while some defines the elementType and then writes documentation in the type definition. There could be more than 1 ways to write documentation. What we need is a robust mechanism (if exists) to get correct documentation for an XSD.
Intellij is somehow pulling it off, so it should be doable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant