From 1791bdbe55a5338dd8fe5d3f7f6266bd54f29ccd Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Thu, 23 Jan 2025 18:58:46 -1000 Subject: [PATCH] refactor: migrate to using asyncio.create_task (#59) --- src/aioharmony/__main__.py | 2 +- src/aioharmony/helpers.py | 2 +- src/aioharmony/hubconnector_websocket.py | 4 ++-- src/aioharmony/responsehandler.py | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/aioharmony/__main__.py b/src/aioharmony/__main__.py index 8e2df95..daddf80 100755 --- a/src/aioharmony/__main__.py +++ b/src/aioharmony/__main__.py @@ -586,7 +586,7 @@ async def run(): hub_ips = args.harmony_ip.split(",") for hub in hub_ips: # Connect to the HUB - hub_tasks.append(asyncio.ensure_future(execute_per_hub(hub, args))) + hub_tasks.append(asyncio.create_task(execute_per_hub(hub, args))) results = await asyncio.gather(*hub_tasks, return_exceptions=True) for result in results: diff --git a/src/aioharmony/helpers.py b/src/aioharmony/helpers.py index d088851..0615dc6 100644 --- a/src/aioharmony/helpers.py +++ b/src/aioharmony/helpers.py @@ -112,7 +112,7 @@ async def wrapped(): return wrapped partial_func = async_partial(callback, result) - task = asyncio.ensure_future(partial_func()) + task = asyncio.create_task(partial_func()) _CALLBACK_TASKS.add(task) task.add_done_callback(_CALLBACK_TASKS.discard) return True diff --git a/src/aioharmony/hubconnector_websocket.py b/src/aioharmony/hubconnector_websocket.py index db8f45d..e3773f4 100644 --- a/src/aioharmony/hubconnector_websocket.py +++ b/src/aioharmony/hubconnector_websocket.py @@ -192,7 +192,7 @@ async def hub_connect(self, is_reconnect: bool = False) -> bool: # Now put the listener on the loop. if not self._listener_task: - self._listener_task = asyncio.ensure_future( + self._listener_task = asyncio.create_task( self._listener(self._websocket) ) @@ -301,7 +301,7 @@ async def hub_send( "Accept-Charset": "utf-8", } json_request = {"id ": msgid, "cmd": command, "params": {}} - response = asyncio.ensure_future(self.hub_post(url, json_request, headers)) + response = asyncio.create_task(self.hub_post(url, json_request, headers)) return response # Make sure we're connected. diff --git a/src/aioharmony/responsehandler.py b/src/aioharmony/responsehandler.py index 34dc37d..25d03dd 100644 --- a/src/aioharmony/responsehandler.py +++ b/src/aioharmony/responsehandler.py @@ -57,7 +57,7 @@ def __init__(self, message_queue: asyncio.Queue, name: str = None) -> None: self._name = name self._handler_list = [] - self._callback_task = asyncio.ensure_future(self._callback_handler()) + self._callback_task = asyncio.create_task(self._callback_handler()) async def close(self): """