Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename click/open/close "commands" to "actions" #4

Open
BlitzOffline opened this issue Dec 23, 2023 · 0 comments
Open

Rename click/open/close "commands" to "actions" #4

BlitzOffline opened this issue Dec 23, 2023 · 0 comments
Labels
deprecation Deprecate or remove a feature enhancement New feature or request

Comments

@BlitzOffline
Copy link
Member

DeluxeMenus supports more than just commands execution and so I believe "actions" would be a better suited term.

I think a fair transition would be as follows:

  • we add new options: click_actions, open_actions and close_actions
  • after the change was uploaded to spigot we update the wiki to only show "actions" instead of "commands
  • we support "commands" for a few updates
  • we remove "commands" support in favor of "actions"
  • one optional step would be a simple app that replaces all instances of strings such as "close_commands" to "close_actions"

The only issue to be discussed is how having both "commands" and actions for an item would work.
My initial idea would be to completely ignore "commands" if "actions" are specified as this suggests the user is aware of what "actions" are and why they were added. Also, giving a warning in console together with the previously stated solution sounds fair to me.

@BlitzOffline BlitzOffline added the enhancement New feature or request label Dec 30, 2023
@BlitzOffline BlitzOffline added the deprecation Deprecate or remove a feature label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecate or remove a feature enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant