Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "has nbt" requirement type #7

Open
BlitzOffline opened this issue Dec 23, 2023 · 4 comments
Open

Add "has nbt" requirement type #7

BlitzOffline opened this issue Dec 23, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@BlitzOffline
Copy link
Member

It was suggested in the HelpChat Discord server that we add a new requirement type that would allow menus to check if specific NBT tags are set, what value they have, etc.

We would have to first decide if this is a good idea or not and then what are all the features this will add and how they will look like.

Source:
https://discord.com/channels/164280494874165248/164280494874165248/929161941346312212

@Starmism Starmism added the enhancement New feature or request label Dec 30, 2023
@Oribuin
Copy link
Contributor

Oribuin commented Jan 8, 2024

With the CheckItem Expansion, id regard this feature as pretty redundant to implement and unnecessary workload.

@cj89898
Copy link
Contributor

cj89898 commented Jan 24, 2024

With the CheckItem Expansion, id regard this feature as pretty redundant to implement and unnecessary workload.

This would be unrelated to items. Talking about NBT data for players.

I also just noticed the ScoreboardTags expansion on the ecloud, and this seems like it could be easy to implement.
I just tested the expansion, and it works; for those of you that want to implement it in your menus before it (possibly) gets implemented into deluxemenus

@BlitzOffline
Copy link
Member Author

This would be unrelated to items. Talking about NBT data for players.

The initial idea was to add the requirement for items. I didn't even consider it might also be used for other stuff such as players.

I am still not sure if this is a good idea or not. We have been trying very hard to remove any unnecessary NBT usage from DeluxeMenus.

Work on a proper API is also going to begin soon (hopefully) so this issue might be irrelevant then.

@cj89898
Copy link
Contributor

cj89898 commented Jan 26, 2024

The initial idea was to add the requirement for items. I didn't even consider it might also be used for other stuff such as players.

Oh I see. The user in discord was wanting to check if a player had an NBT tag, not if the player had an item with an nbt tag with a specific value.

Either way, right now both of these things can be done with the CheckItem/ScoreboardTags expansions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants