Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom on window resize or minimize / restore resets to 100% #3418

Open
MontblancKupo opened this issue Jan 8, 2024 · 3 comments · May be fixed by #4020
Open

Zoom on window resize or minimize / restore resets to 100% #3418

MontblancKupo opened this issue Jan 8, 2024 · 3 comments · May be fixed by #4020
Labels
bug:unconfirmed Someone works on identifying the issue

Comments

@MontblancKupo
Copy link

Describe the bug

Zoom level set in accessibility not retained.

Add logs

(09:18:23) INFO:    [Legendary]:        Legendary location: C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary
(09:18:23) INFO:    [Gog]:              GOGDL location: C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl
(09:18:23) INFO:    [Connection]:       Connectivity: check-online
(09:18:23) INFO:    [Connection]:       Pinging external endpoints
(09:18:23) INFO:    [Nile]:             Refreshing library...
(09:18:23) INFO:    [Nile]:             Refreshing Amazon Games...
(09:18:23) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\nile_config C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile library sync
(09:18:23) INFO:    [Nile]:             Game list updated, got 327 games
(09:18:23) INFO:    [Backend]:          DRM module staus {
  "neifaoindggfcjicffkgpmnlppeffabd": {
    "name": "Google Widevine Windows CDM",
    "status": "new",
    "version": "1.0.2738.0"
  },
  "oimompecagnajdejgnnjijobebaeigek": {
    "name": "Widevine Content Decryption Module",
    "status": "new",
    "version": "4.10.2710.0"
  }
}
(09:18:23) WARNING: [Backend]:          Protocol already registered.
(09:18:23) INFO:    [Connection]:       Connectivity: online
(09:18:23) INFO:    [Gog]:              Checking if login is valid
(09:18:23) INFO:    [Gog]:              Running command: C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\natha\AppData\Roaming\heroic\gog_store\auth.json auth
(09:18:24) INFO:    [Nile]:             Saved user data to config file
(09:18:24) INFO:    [Frontend]:         Refreshing undefined Library
(09:18:24) WARNING: [Backend]:          refresh not implemented on Sideload Library Manager
(09:18:24) INFO:    [Gog]:              Running command: C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\natha\AppData\Roaming\heroic\gog_store\auth.json auth
(09:18:24) INFO:    [Legendary]:        Refreshing library...
(09:18:24) INFO:    [Legendary]:        Refreshing Epic Games...
(09:18:24) INFO:    [Nile]:             Refreshing library...
(09:18:24) INFO:    [Nile]:             Refreshing Amazon Games...
(09:18:24) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\nile_config C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile library sync
(09:18:24) INFO:    [Nile]:             Game list updated, got 327 games
(09:18:25) INFO:    [Legendary]:        Game list updated, got 461 games & DLCs
(09:18:25) INFO:    [Backend]:          Frontend Ready
(09:18:25) INFO:    [Backend]:          Checking for new Heroic Updates
(09:18:25) INFO:    [Backend]:          Checking for current version changelog
(09:18:25) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\legendaryConfig\legendary C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary list --third-party
(09:18:25) INFO:    [Gog]:              Getting GOG library
(09:18:25) INFO:    [Gog]:              Running command: C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\natha\AppData\Roaming\heroic\gog_store\auth.json auth
(09:18:26) DEBUG:   [Backend]:          Unable to load Steam Libraries, libraryfolders.vdf not found
(09:18:26) INFO:    [Gog]:              Saved username to config file
(09:18:27) INFO:    [Backend]:          VCRuntime is installed
(09:18:27) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\legendaryConfig\legendary C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary --version
(09:18:27) INFO:    [Gog]:              Running command: C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\natha\AppData\Roaming\heroic\gog_store\auth.json --version
(09:18:27) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\nile_config C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile --version
(09:18:30) INFO:    [Backend]:          Starting the Download Queue
(09:18:30) ERROR:   [ExtraGameInfo]:    Was not able to get GamesDB data for 1198772268 Release with per platform id: gog_1198772268 not found
(09:18:30) INFO:    [Backend]:          
System Information:
CPU: 4x Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz
Memory: 17.14 GB (used: 7.79 GB)
GPUs:
  GPU 0:
    Name: NVIDIA Corporation TU104 [GeForce RTX 2080 SUPER]
    IDs: D=1e81 V=10de SD=37b1 SV=1462
    Driver: 546.33
OS: Microsoft Windows 10 Home 10.0.19045 (win32)

The current system is not a Steam Deck
We are not running inside a Flatpak container

Software Versions:
  Heroic: 2.12.0 Vegapunk
  Legendary: 0.20.34 Direct Intervention
  gogdl: 0.7.3
  Nile: 1.0.0 Jonathan Joestar

(09:18:32) ERROR:   [ExtraGameInfo]:    Was not able to get GamesDB data for 1198772268 Release with per platform id: gog_1198772268 not found
(09:18:35) ERROR:   [ExtraGameInfo]:    Was not able to get GamesDB data for 1198772268 Release with per platform id: gog_1198772268 not found
(09:18:37) ERROR:   [ExtraGameInfo]:    Was not able to get GamesDB data for 1198772268 Release with per platform id: gog_1198772268 not found
(09:18:39) ERROR:   [ExtraGameInfo]:    Was not able to get GamesDB data for 1198772268 Release with per platform id: gog_1198772268 not found
(09:18:41) INFO:    [Gog]:              Saved games data
(09:18:41) WARNING: [Backend]:          listUpdateableGames not implemented on Sideload Library Manager
(09:18:47) INFO:    [Gog]:              Found 0 game(s) to update
(09:18:48) INFO:    [Legendary]:        Checking for game updates: LEGENDARY_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\legendaryConfig\legendary C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary list --third-party
(09:18:51) INFO:    [Legendary]:        Found 0 games to update
(09:18:51) INFO:    [Nile]:             Looking for updates...
(09:18:51) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\nile_config C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile list-updates --json
(09:18:55) INFO:    [Legendary]:        Running command: LEGENDARY_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\legendaryConfig\legendary C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary --version
(09:18:55) INFO:    [Gog]:              Running command: C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\gogdl --auth-config-path C:\Users\natha\AppData\Roaming\heroic\gog_store\auth.json --version
(09:18:55) INFO:    [Nile]:             Running command: NILE_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\nile_config C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\nile --version
(09:18:55) INFO:    [Legendary]:        Checking if EOS Overlay is enabled: LEGENDARY_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\legendaryConfig\legendary C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary eos-overlay info
(09:18:57) INFO:    [Legendary]:        Abort command "LEGENDARY_CONFIG_PATH=C:\Users\natha\AppData\Roaming\heroic\legendaryConfig\legendary C:\Users\natha\AppData\Local\Programs\heroic\resources\app.asar.unpacked\build\bin\win32\legendary eos-overlay info"

Steps to reproduce

  1. Set zoom to 80% in accessibility menu.

  2. Return to library window and properly set to 80%.

  • Moving window functions properly and retains size unless it is moved to a second monitor.
  • Minimizing window and restoring returns to 100%.
  • Maximizing window and restoring returns to 100%.
  • Resizing window returns to 100%.

3.5 If application is closed and reopened it will return to 80%

Expected behavior

Setting zoom retains zoom level chosen.

Screenshots

No response

Heroic Version

Latest Stable

System Information

Windows 10 x64 (Version 10.0.19045 Build 19045)
Heroic 2.12.0

Additional information

No response
@MontblancKupo MontblancKupo added the bug:unconfirmed Someone works on identifying the issue label Jan 8, 2024
@arielj
Copy link
Collaborator

arielj commented Jan 8, 2024

😢 I thought I had that fixed, that's sad

seems to be an issue with electron (we don't reset the zoom in any way), I'll do more testing when I have some time

@MontblancKupo
Copy link
Author

Just checking in after the recent patch. Still same behavior on 2.13, win10.

@error161 error161 mentioned this issue Feb 19, 2024
Closed
@MontblancKupo
Copy link
Author

MontblancKupo commented Apr 22, 2024 •
edited
Loading

win10, 2.14.1. Behavior is slightly better. Launching heroic.. if I minimize and restore at library it seems ok... but if I switch to another tab and minimize then restore it goes back to default 100% size again. Maximize and restore seems to do it as well.. .though not as consistently.

@arielj arielj mentioned this issue Aug 17, 2024
Closed
@CommandMC CommandMC linked a pull request Nov 1, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:unconfirmed Someone works on identifying the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Zoom now always retained after minimize, restore, etc. hitgubian/HeroicGamesLauncher
2 participants
@arielj @MontblancKupo