Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql: update boost-check.patch #900

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

bevanjkay
Copy link
Member

Updates the patch to work with mysql 8.2.0 CMakeList.txt

Updates the patch to work with mysql `8.2.0` CMakeList.txt
@SMillerDev
Copy link
Member

Is this submitted upstream again?

@bevanjkay
Copy link
Member Author

bevanjkay commented Nov 28, 2023

No it isn't. I think per last iteration of this patch it's homebrew specific.

Ref: #870 (comment)

I don't understand the patch myself, I just retrofitted it to the updated CMakeFileList from upstream.

@SMillerDev
Copy link
Member

We should really still try to submit it, even if it's just for upstream to review

@Bo98
Copy link
Member

Bo98 commented Nov 28, 2023

We can probably ask for them to add an option. That would remove the need for this patch.

The code we're patching out here is code that's unfortunately specific to their build environment (possibly build flags not in the correct order) and causes issues for us shipping it as it prevents having boost installed at the same time as MySQL, which is why we're forced to remove it. The reasons for upstream having the code do not apply to our superenv - we've never had an issue of Boost conflicting with MySQL. We've tested many combinations of that and the correct bundled Boost is used each time.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Dec 20, 2023
@bevanjkay
Copy link
Member Author

I don't have permission to merge this here, but it's approved. Since it is merged into mysql via the commit hash already, is it ok for someone with write permission to merge?

@github-actions github-actions bot removed the stale label Dec 21, 2023
@ZhongRuoyu ZhongRuoyu merged commit 1076e34 into Homebrew:master Dec 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants