Skip to content
This repository was archived by the owner on Jun 10, 2025. It is now read-only.

Use v3 SQL instead of v1 InfluxDB API #458

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jun 21, 2024

PyCall approach.

The whole migration should fix count_being_weird_categories stuff and also fix (presumably) inaccurate analytics data we are seeing: https://formulae.brew.sh/analytics/os-version/30d/.

Bulk of the code required an extra nest as data is now streamed in batches so I recommend viewing the diff with whitespace disabled.

Replaces and closes #440

@Bo98
Copy link
Member Author

Bo98 commented Jun 21, 2024

This may require adding actions/setup-python to formulae.brew.sh CI.

Could also brew install python@version within the command, though at the cost of being a bit slower (setup-python uses pre-cached Pythons).

Or another option is to just make the command set the PATH to $RUNNER_TOOL_CACHE/Python/3.12/x64/bin in CI (though RUNNER_TOOL_CACHE is currently env-filtered).

@SMillerDev
Copy link
Member

I'd say setup-Python

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Bo98!

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Jul 13, 2024
@Bo98 Bo98 removed the stale label Jul 13, 2024
@MikeMcQuaid
Copy link
Member

Great work here, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 58a9ac6 into master Jul 14, 2024
4 checks passed
@MikeMcQuaid MikeMcQuaid deleted the influxdb-pycall branch July 14, 2024 14:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants