Skip to content

httpapi: suspicious condition in srv_test.go #164

@quasilyte

Description

@quasilyte

if r == nil && r == fmt.Sprintf("Failed to start HTTPS service - %s", errMessage) {

Looks like there is a mistake inside 3 recovers inside that file.
If r is nil, it can't match sprintf result, so there is something wrong here.
I would guess that && should be changed to ||, but r == fmt.Sprintf(...) also look incorrect.
Anyway, I don't have any context, it looks like it tries to test that panic is caught and that the value returned by recover match the expected one. Code inside tests doesn't do that in a clear way. right now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions