-
Notifications
You must be signed in to change notification settings - Fork 260
Open
Description
Line 131 in 7910332
if r == nil && r == fmt.Sprintf("Failed to start HTTPS service - %s", errMessage) { |
Looks like there is a mistake inside 3 recovers inside that file.
If r
is nil
, it can't match sprintf
result, so there is something wrong here.
I would guess that &&
should be changed to ||
, but r == fmt.Sprintf(...)
also look incorrect.
Anyway, I don't have any context, it looks like it tries to test that panic is caught and that the value returned by recover
match the expected one. Code inside tests doesn't do that in a clear way. right now.
HouzuoGuo
Metadata
Metadata
Assignees
Labels
No labels