Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeOnly.ToClockNotation with german culture returns english like time #1532

Open
RenNagasaki opened this issue Aug 16, 2024 · 1 comment · May be fixed by #1536
Open

TimeOnly.ToClockNotation with german culture returns english like time #1532

RenNagasaki opened this issue Aug 16, 2024 · 1 comment · May be fixed by #1536

Comments

@RenNagasaki
Copy link

If you use .ToClockNotation on a TimeOnly object created with german culture it still returns the english time definition.

Like: 08:30 becomes "half past acht". (The number is correctly translated but not the description of the time)
It should be either: "halb neun" or "acht uhr dreißig".
This goes for all variants of time. :45/:15

Using it with a time like: 8:37 returns "acht siebenunddreißig"
but should be "acht uhr siebenunddreißig".
grafik

I hope I made clear what I mean.

Kind regards,
Ren
@hangy
Copy link
Contributor

hangy commented Aug 17, 2024

True, this extension is currently only implemented for a handful of languages:

Humanizer/src/Humanizer/Configuration/TimeOnlyToClockNotationConvertersRegistry.cs

Lines 8 to 14 in 1dee67d

{
Register("pt-BR", new BrazilianPortugueseTimeOnlyToClockNotationConverter());
Register("fr", new FrTimeOnlyToClockNotationConverter());
Register("es", new EsTimeOnlyToClockNotationConverter());
Register("lb", new LbTimeOnlyToClockNotationConverter());
Register("pt", new PortugueseTimeOnlyToClockNotationConverter());
}

@RenNagasaki RenNagasaki linked a pull request Aug 24, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add german TimeOnly.ToClockNotationConverter RenNagasaki/Humanizer
2 participants
@hangy @RenNagasaki