Skip to content

Commit b75a00e

Browse files
authored
fix socket status if socket is already closed (#346)
1 parent dc3aef2 commit b75a00e

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

packages/embed-react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@humeai/voice-embed-react",
3-
"version": "0.2.0-beta.16",
3+
"version": "0.2.0-beta.17",
44
"description": "",
55
"main": "./dist/index.js",
66
"module": "./dist/index.mjs",

packages/embed/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@humeai/voice-embed",
3-
"version": "0.2.0-beta.16",
3+
"version": "0.2.0-beta.17",
44
"description": "",
55
"main": "./dist/index.js",
66
"module": "./dist/index.mjs",

packages/react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@humeai/voice-react",
3-
"version": "0.2.0-beta.16",
3+
"version": "0.2.0-beta.17",
44
"description": "",
55
"main": "./dist/index.js",
66
"module": "./dist/index.mjs",

packages/react/src/lib/VoiceProvider.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,7 @@ export const VoiceProvider: FC<VoiceProviderProps> = ({
618618
isConnectingRef.current = false;
619619
},
620620
[
621+
checkIsDisconnecting,
621622
checkShouldContinueConnecting,
622623
client,
623624
config,
@@ -651,7 +652,12 @@ export const VoiceProvider: FC<VoiceProviderProps> = ({
651652

652653
// WEBSOCKET - shut this down before shutting down the audio player
653654
if (client.readyState !== VoiceReadyState.CLOSED) {
655+
// socket is open, so close it. resourceStatusRef will be set to 'disconnected'
656+
// in the onClose callback of the websocket client.
654657
client.disconnect();
658+
} else {
659+
// socket is already closed, so ensure that the socket status is appropriately set
660+
resourceStatusRef.current.socket = 'disconnected';
655661
}
656662
// resourceStatusRef.current.socket is not set to 'disconnected' here,
657663
// but rather in the onClose callback of the client. This is because

0 commit comments

Comments
 (0)