-
Notifications
You must be signed in to change notification settings - Fork 52
Inconsistent Table Header Styling - No Longer Bold After Upgrade #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the thorough writeup for this issue.
Yes, it was incidental due to the change to using
Yes
Yes. That is a good catch. We have not been testing bold in the headers.
|
paulaldridge
added a commit
to paulaldridge/ibm-cloud-cli-sdk
that referenced
this issue
May 28, 2025
This change explicitly sets the header style to bold in PrintableTable.Print() to align with the IBM Cloud CLI Plugin Developer Guide (Section 2.11). Fixes IBM-Cloud#446
Thanks @Aerex - I've made a PR with the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi team,
We've noticed a change in table output formatting after upgrading the SDK. Specifically, table headers are no longer rendered in bold, which seems to conflict with the IBM Cloud CLI plugin developer guide.
What's Happening
In
PrintableTable.Print()
, ago-pretty
table writer is created and configured, but header styling is not explicitly set:Version History
We observed this behaviour when upgrading from:
github.com/IBM-Cloud/ibm-cloud-cli-sdk v1.5.0
to
v1.6.2
(which introducedgo-pretty/v6 v6.6.1
)We also tried updating to
v1.7.1
, and the behaviour remains unchanged - headers still render as plain text.Developer Guide Inconsistency
According to the IBM Cloud CLI Plugin Developer Guide (Section 2.11):
This suggests that bold headers are still part of the intended user experience.
Proposed Fix
To align with the documented guidance and preserve visual consistency across CLI plugins, consider adding this line to
PrintableTable.Print()
:This would restore bold headers and ensure compatibility with future
go-pretty
updates.Questions
go-pretty
?Thanks for maintaining the SDK! Happy to help further if needed.
The text was updated successfully, but these errors were encountered: