Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to filter bad proof steps from the data loader #50

Open
jasonrute opened this issue Aug 5, 2022 · 1 comment
Open

Add ability to filter bad proof steps from the data loader #50

jasonrute opened this issue Aug 5, 2022 · 1 comment
Assignees

Comments

@jasonrute
Copy link
Collaborator

jasonrute commented Aug 5, 2022

Add options to the data loader to filter out:

@fidel-schaposnik
Copy link
Collaborator

I've now implemented the first two items here. However, note that I've leaned on doing this at the TF-GNN level instead of the loader level, because I think we should stick to the useful conceptual separation:

  • The loader limits itself to exposing data from the capnp dataset
  • The various modules (TF2, TFGNN, etc) do whatever they like with this data

Eventually, I'd like to clean up the loader from other stuff that is cluttering it and not being used (e.g. train/validation splits), but for now at least I think we should not add here higher-level functionality.

Anyway, maybe we can close this issue and keep #9 as a reminder of what is left?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants