From 574271f618e62395fc157ad1649e8dd39552ac5e Mon Sep 17 00:00:00 2001
From: Pierre Romera <hello@pirhoo.com>
Date: Thu, 25 Jul 2024 08:18:22 +0000
Subject: [PATCH] feat: add document download popover

---
 components.d.ts                               |   4 +-
 .../DocumentActionsGroup.vue                  |  14 +-
 .../DocumentActionsGroupEntry.vue             |   7 +
 .../DocumentDownloadPopover.vue               | 131 ++++++++++++++++++
 .../DocumentDownloadPopoverSection.vue        |  21 +++
 src/components/PageTable/PageTable.vue        |   1 +
 src/components/PageTable/PageTableTh.vue      |   2 +-
 src/lang/en.json                              |   3 +
 src/main.scss                                 |   5 -
 .../DocumentActionsGroup.stories.js           |  51 ++++---
 .../DocumentDownloadPopover.stories.js        |  58 ++++++++
 src/utils/settings.scss                       |   2 +
 12 files changed, 267 insertions(+), 32 deletions(-)
 create mode 100644 src/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.vue
 create mode 100644 src/components/Document/DocumentDownloadPopover/DocumentDownloadPopoverSection.vue
 create mode 100644 src/stories/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.stories.js

diff --git a/components.d.ts b/components.d.ts
index dcf77da9dd..7638edcb41 100644
--- a/components.d.ts
+++ b/components.d.ts
@@ -64,7 +64,7 @@ declare module 'vue' {
     ColumnFilterBadge: typeof import('./src/components/ColumnFilterBadge.vue')['default']
     ColumnFilterDropdown: typeof import('./src/components/ColumnFilterDropdown.vue')['default']
     ContentTypeBadge: typeof import('./src/components/ContentTypeBadge.vue')['default']
-    copy: typeof import('./src/components/PageTable/PageTableTh copy.vue')['default']
+    copy: typeof import('./src/components/Document/DocumentDownloadPopover copy.vue')['default']
     DismissableAlert: typeof import('./src/components/Dismissable/DismissableAlert.vue')['default']
     DismissableToastBody: typeof import('./src/components/Dismissable/DismissableToastBody.vue')['default']
     DisplayContentLength: typeof import('./src/components/Display/DisplayContentLength.vue')['default']
@@ -104,6 +104,8 @@ declare module 'vue' {
     DocumentContentSlice: typeof import('./src/components/DocumentContentSlice.vue')['default']
     DocumentContentSlicePlaceholder: typeof import('./src/components/DocumentContentSlicePlaceholder.vue')['default']
     DocumentContentSlices: typeof import('./src/components/DocumentContentSlices.vue')['default']
+    DocumentDownloadPopover: typeof import('./src/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.vue')['default']
+    DocumentDownloadPopoverSection: typeof import('./src/components/Document/DocumentDownloadPopover/DocumentDownloadPopoverSection.vue')['default']
     DocumentGlobalSearchTermsTags: typeof import('./src/components/DocumentGlobalSearchTermsTags.vue')['default']
     DocumentInModal: typeof import('./src/components/DocumentInModal.vue')['default']
     DocumentLocalSearch: typeof import('./src/components/Document/DocumentLocalSearch/DocumentLocalSearch.vue')['default']
diff --git a/src/components/Document/DocumentActionsGroup/DocumentActionsGroup.vue b/src/components/Document/DocumentActionsGroup/DocumentActionsGroup.vue
index dbc91c533d..848ad0c66b 100644
--- a/src/components/Document/DocumentActionsGroup/DocumentActionsGroup.vue
+++ b/src/components/Document/DocumentActionsGroup/DocumentActionsGroup.vue
@@ -22,10 +22,11 @@
         @click="clickShare"
       />
       <document-actions-group-entry
+        ref="downloadButton"
         icon="download"
         :label="$t('documentActionsGroup.download')"
-        :disabled="isDownloadAllowed"
-        :tooltip-placement="tooltipPlacement"
+        :disabled="!isDownloadAllowed"
+        hide-tooltip
         @click="clickDownload"
       />
       <document-actions-group-entry
@@ -34,12 +35,19 @@
         :tooltip-placement="tooltipPlacement"
         @click="clickExpand"
       />
+      <document-download-popover :target="downloadButton" :document="document" :placement="tooltipPlacement" />
     </slot>
   </div>
 </template>
 
 <script setup>
-import DocumentActionsGroupEntry from '@/components/Document/DocumentActionsGroup/DocumentActionsGroupEntry'
+import { ref } from 'vue'
+
+import DocumentActionsGroupEntry from './DocumentActionsGroupEntry'
+
+import DocumentDownloadPopover from '@/components/Document/DocumentDownloadPopover/DocumentDownloadPopover'
+
+const downloadButton = ref(null)
 
 defineProps({
   /**
diff --git a/src/components/Document/DocumentActionsGroup/DocumentActionsGroupEntry.vue b/src/components/Document/DocumentActionsGroup/DocumentActionsGroupEntry.vue
index e7b0425ceb..4016e97ea2 100644
--- a/src/components/Document/DocumentActionsGroup/DocumentActionsGroupEntry.vue
+++ b/src/components/Document/DocumentActionsGroup/DocumentActionsGroupEntry.vue
@@ -6,6 +6,7 @@
     :icon-left-hover-weight="iconHoverWeight"
     :label="label"
     hide-label
+    :hide-tooltip="hideTooltip"
     :tooltip-placement="tooltipPlacement"
     square
     variant="outline-tertiary"
@@ -50,6 +51,12 @@ const props = defineProps({
   fill: {
     type: Boolean
   },
+  /**
+   * Hide the button tooltip
+   */
+  hideTooltip: {
+    type: Boolean
+  },
   /**
    * Class to apply to the action button when document is fill
    */
diff --git a/src/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.vue b/src/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.vue
new file mode 100644
index 0000000000..ae6ac85121
--- /dev/null
+++ b/src/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.vue
@@ -0,0 +1,131 @@
+<script setup>
+import { computed } from 'vue'
+import { PhosphorIcon } from '@icij/murmur-next'
+import { useI18n } from 'vue-i18n'
+
+import DocumentDownloadPopoverSection from './DocumentDownloadPopoverSection'
+
+import DisplayContentType from '@/components/Display/DisplayContentType'
+
+const props = defineProps({
+  /**
+   * The selected document
+   */
+  document: {
+    type: Object
+  },
+  /**
+   * The target element
+   */
+  target: {
+    type: Object
+  },
+  /**
+   * Toggle value when the popover is open
+   */
+  modelValue: {
+    type: Boolean
+  },
+  /**
+   * True if the popover is open manually
+   */
+  manual: {
+    type: Boolean
+  },
+  /**
+   * Disable auto close
+   */
+  noAutoClose: {
+    type: Boolean
+  },
+  /**
+   * The placement of the popover
+   */
+  placement: {
+    type: String
+  }
+})
+
+const { locale, t } = useI18n()
+
+const extensionWarning = computed(() => {
+  const { standardExtension: extension } = props.document
+  return t('documentDownloadPopover.extensionWarning', { extension })
+})
+
+const description = computed(() => {
+  const descriptions = props.document.contentTypeDescription ?? {}
+  const description = descriptions[locale.value] || descriptions.en
+  return props.document.hasStandardExtension ? description : `${description} <strong>${extensionWarning.value}</strong>`
+})
+
+const executionWarning = computed(() => {
+  const warnings = props.document.contentTypeWarning ?? {}
+  return warnings[locale.value] || warnings.en
+})
+</script>
+
+<template>
+  <b-popover
+    teleport-to="body"
+    :target="target"
+    :manual="manual"
+    :model-value="modelValue"
+    :no-auto-close="noAutoClose"
+    :placement="placement"
+    custom-class="document-download-popover"
+    @update:modelValue="$emit('update:modelValue')"
+  >
+    <div class="document-download-popover__body">
+      <icon-button icon-left="download-simple" label="Download" class="document-download-popover__body__button" />
+      <icon-button
+        icon-left="download-simple"
+        label="Download without metadata"
+        variant="outline-primary"
+        class="document-download-popover__body__button"
+      />
+      <icon-button
+        icon-left="download-simple"
+        label="Download extract text"
+        variant="outline-primary"
+        class="document-download-popover__body__button"
+      />
+      <div class="document-download-popover__body__sections pt-3">
+        <document-download-popover-section title="What's the document's title?" :value="document.title" />
+        <document-download-popover-section title="What's the document's type">
+          <phosphor-icon :name="document.contentTypeIcon" class="me-2" />
+          <display-content-type :value="document.contentType" />
+        </document-download-popover-section>
+        <document-download-popover-section
+          v-if="description"
+          title="Once downloaded, how do I open it ?"
+          :value="description"
+        />
+      </div>
+    </div>
+  </b-popover>
+</template>
+
+<style lang="scss">
+.document-download-popover {
+  width: 100%;
+
+  &__body {
+    display: flex;
+    flex-direction: column;
+    gap: $spacer-sm;
+
+    &__button {
+      white-space: nowrap;
+      align-self: flex-start;
+    }
+
+    &__sections {
+      margin-top: $spacer;
+      display: flex;
+      flex-direction: column;
+      gap: $spacer-xl;
+    }
+  }
+}
+</style>
diff --git a/src/components/Document/DocumentDownloadPopover/DocumentDownloadPopoverSection.vue b/src/components/Document/DocumentDownloadPopover/DocumentDownloadPopoverSection.vue
new file mode 100644
index 0000000000..c3ab3c1437
--- /dev/null
+++ b/src/components/Document/DocumentDownloadPopover/DocumentDownloadPopoverSection.vue
@@ -0,0 +1,21 @@
+<script setup>
+defineProps({
+  title: {
+    type: String
+  },
+  value: {
+    type: String
+  }
+})
+</script>
+
+<template>
+  <section class="document-download-popover-section">
+    <div class="document-download-popover-section__title pb-2 text-tertiary-emphasis fst-italic">
+      {{ title }}
+    </div>
+    <div class="document-download-popover-section__value text-primary-emphasis">
+      <slot><span v-html="value"></span></slot>
+    </div>
+  </section>
+</template>
diff --git a/src/components/PageTable/PageTable.vue b/src/components/PageTable/PageTable.vue
index f255a7d26e..baefa3e1b4 100644
--- a/src/components/PageTable/PageTable.vue
+++ b/src/components/PageTable/PageTable.vue
@@ -37,6 +37,7 @@ const classList = computed(() => {
 
 <style lang="scss" scoped>
 .page-table {
+  vertical-align: middle;
   font-size: math.div(14, 16) * 1rem;
 
   &__select {
diff --git a/src/components/PageTable/PageTableTh.vue b/src/components/PageTable/PageTableTh.vue
index d0a4c241f1..f2815e738a 100644
--- a/src/components/PageTable/PageTableTh.vue
+++ b/src/components/PageTable/PageTableTh.vue
@@ -70,7 +70,7 @@ const labelClassList = computed(() => {
 
 <style lang="scss" scoped>
 .page-table-th {
-  vertical-align: $table-cell-vertical-align;
+  vertical-align: middle;
 
   &--compact {
     width: 2rem;
diff --git a/src/lang/en.json b/src/lang/en.json
index d4764b628e..568d1bbd60 100644
--- a/src/lang/en.json
+++ b/src/lang/en.json
@@ -42,6 +42,9 @@
     "private": "Private to you",
     "public": "Public to project members"
   },
+  "documentDownloadPopover": {
+    "extensionWarning": "This document has the wrong file extension for its type. You might need to add the extension <code>{extension}</code> before you can open it."
+  },
   "error": {
     "title": "Something's wrong here",
     "description": "An error has occurred. Please try again later or contact your administrator if the problem persists.",
diff --git a/src/main.scss b/src/main.scss
index c52a437714..7494820dda 100644
--- a/src/main.scss
+++ b/src/main.scss
@@ -218,11 +218,6 @@ $value in $theme-colors {
     border-radius: inherit;
     overflow: hidden;
   }
-
-  &.bs-popover-bottom > .popover-arrow::after,
-  &.bs-popover-auto[data-popper-placement^="bottom"] > .popover-arrow::after {
-    border-bottom-color: $popover-header-bg;
-  }
 }
 
 html[data-bs-theme] body .Toastify {
diff --git a/src/stories/components/Document/DocumentActionsGroup/DocumentActionsGroup.stories.js b/src/stories/components/Document/DocumentActionsGroup/DocumentActionsGroup.stories.js
index c28730d306..00f8d8778c 100644
--- a/src/stories/components/Document/DocumentActionsGroup/DocumentActionsGroup.stories.js
+++ b/src/stories/components/Document/DocumentActionsGroup/DocumentActionsGroup.stories.js
@@ -1,37 +1,44 @@
-import IconButton from '@/components/IconButton'
+import { markRaw } from 'vue'
+import { PhFilePdf } from '@phosphor-icons/vue'
+
+import types from '@/utils/types.json'
 import DocumentActionsGroup from '@/components/Document/DocumentActionsGroup/DocumentActionsGroup'
 
 export default {
   components: { DocumentActionsGroup },
   title: 'Components/Document/DocumentActionsGroup',
-  component: IconButton,
+  component: DocumentActionsGroup,
   tags: ['autodocs'],
-  render: (args) => ({
-    components: {
-      DocumentActionsGroup
-    },
-    setup() {
-      return {
-        args
-      }
-    },
-    template: `
-      <document-actions-group v-bind="args" >
-      </document-actions-group>
-    `
-  })
-}
-
-export const Default = {
   args: {
     document: {
-      id: 'test'
+      id: '5f5b3b3b-7b3b-4b3b-8b3b-3b3b3b3b3b3b',
+      title: 'Inter IKEA Investment S.à r.l._cover letter 2010-2011 tax returns.pdf',
+      extractionLevel: 0,
+      project: 'banana-papers',
+      creationDate: new Date(),
+      inlineFullUrl: 'https://i.imgur.com/ns9ThQx.jpeg',
+      path: '/vault/ns9ThQx.jpeg',
+      tags: ['foo', 'bar', 'baz'],
+      language: 'ENGLISH',
+      contentLength: 23e4,
+      contentTextLength: 14e3,
+      isSupportedImage: true,
+      highlights: [
+        'Lorem ispum dolor sit <mark>IKEA</mark> amet.',
+        'Consectetur <mark>IKEA</mark> adipiscing elit.',
+        'Sed do eiusmod tempor incididunt ut labore et <mark>IKEA</mark> dolore magna aliqua.'
+      ],
+      contentType: 'application/pdf',
+      contentTypeDescription: types['application/pdf'].description,
+      contentTypeIcon: markRaw(PhFilePdf)
     },
     vertical: false,
-    tooltipPlacement: 'top',
+    tooltipPlacement: 'bottom',
     isStarred: false,
-    isDownloadAllowed: false,
+    isDownloadAllowed: true,
     selectMode: true,
     selected: false
   }
 }
+
+export const Default = {}
diff --git a/src/stories/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.stories.js b/src/stories/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.stories.js
new file mode 100644
index 0000000000..e243afd553
--- /dev/null
+++ b/src/stories/components/Document/DocumentDownloadPopover/DocumentDownloadPopover.stories.js
@@ -0,0 +1,58 @@
+import { markRaw } from 'vue'
+import { PhFile, PhFilePdf } from '@phosphor-icons/vue'
+
+import DocumentDownloadPopover from '@/components/Document/DocumentDownloadPopover/DocumentDownloadPopover'
+import types from '@/utils/types.json'
+
+export default {
+  component: DocumentDownloadPopover,
+  title: 'Components/Document/DocumentDownloadPopover/DocumentDownloadPopover',
+  tags: ['autodocs'],
+  args: {
+    document: {
+      id: 'foo',
+      title: 'Inter IKEA Investment S.à r.l._cover letter 2010-2011 tax returns.pdf',
+      standardExtension: 'pdf',
+      hasStandardExtension: true,
+      contentType: 'application/pdf',
+      contentTypeDescription: types['application/pdf'].description,
+      contentTypeIcon: markRaw(PhFilePdf)
+    }
+  },
+  render: (args) => ({
+    components: {
+      DocumentDownloadPopover
+    },
+    setup: () => ({ args }),
+    computed: {
+      trigger() {
+        return `btn-${this.$.uid}`
+      }
+    },
+    template: `
+      <div class="p-sm-5 p-3 text-center">
+        <button type="button" class="btn btn-outline-secondary" :id="trigger">
+          Hover me
+        </button>
+        <document-download-popover v-bind="args" :target="trigger" />
+      </div>
+    `
+  })
+}
+
+export const Default = {}
+
+export const WithWarning = {
+  args: {
+    document: {
+      id: 'bar',
+      title: 'Inter IKEA Investment S.à r.l._cover letter 2010-2011 tax returns.txt',
+      contentType: 'text/html',
+      standardExtension: 'html',
+      hasStandardExtension: false,
+      contentTypeDescription: types['text/html'].description,
+      contentTypeWarning: types['text/html'].warning,
+      contentTypeIcon: markRaw(PhFile)
+    }
+  }
+}
diff --git a/src/utils/settings.scss b/src/utils/settings.scss
index 660a6d890a..24ecbaac06 100644
--- a/src/utils/settings.scss
+++ b/src/utils/settings.scss
@@ -120,6 +120,8 @@ $border-radius-xl: 0.5rem;
 $border-radius-xxl: 1rem;
 $border-radius-pill: 50rem;
 
+$box-shadow: 0 4px 8px 3px rgba($black, .07), 0 1px 3px rgba($black, .15);
+
 $alert-border-width: 0;
 
 $input-bg:  var(--bs-body-bg);