Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw Tools Options / color selector #381

Closed
MysticJay opened this issue Jul 26, 2020 · 6 comments · Fixed by #382
Closed

Draw Tools Options / color selector #381

MysticJay opened this issue Jul 26, 2020 · 6 comments · Fixed by #382

Comments

@MysticJay
Copy link
Contributor

What is causing this broken style for the palette?
grafik

0,30.1 (release) with DT 0.7.1 does not show this.
0.30.1 (release) with DT 0.8.0 does not show this
0.30.1.20200720.132610 [test] with DT 0.8.0 shows problem

@McBen
Copy link
Contributor

McBen commented Jul 26, 2020

tracked it down to:
0c90913 - external: update jQuery to 3.5.1

PR: #369

@McBen
Copy link
Contributor

McBen commented Jul 26, 2020

But the full truth is:
It's a bug in spectrum: bgrins/spectrum#563

a missing </span> in plugins/external/spectrum.js#143
should be:
html.push('<span title="' + formattedString + '" data-color="' + tiny.toRgbString() + '" class="' + c + '"><span class="sp-thumb-inner" style="' + swatchStyle + ';" /></span></span>');

@johnd0e

This comment has been minimized.

@johnd0e
Copy link
Contributor

johnd0e commented Jul 27, 2020

a missing </span> in plugins/external/spectrum.js#143

True. And that is already fixed in upstream, so we need just upgrade spectrum to latest.

@MysticJay
Copy link
Contributor Author

Confirming issue solved. still this is a workaround and night need to be reverted.
grafik

@MysticJay
Copy link
Contributor Author

Solution accepted.
upgrade provided with PR#382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants