[FIX] UI: Align Container\Form renderers
#8444
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibsy
force-pushed
the
fix/10/ui-forms-cleanup
branch
from
a7e779c
to
3dab4e4
Compare
thibsy
changed the title
Container\Form renderers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I noticed there are some remnants of the
Form\FormWithoutSubmitButtonscomponent, which has been replaced by a context renderer in #7045. This PR removes the duplicate logic and streamlines both forms, so they use (almost) the same HTML structure and functionalities. While at it, I also noticed that thePrompt\IsPromptContentInternalimplementation was missing and the method declarations were (imo) on the wrong level.Kind regards,
@thibsy