Skip to content

Update Github PR Template #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Jun 16, 2025

What do these changes do?

image

Related issue/s

Related PR/s

Checklist

  • I tested and it works

Ask for docker healthcheck, traefik healthcheck and replicas's count
@YuryHrytsuk YuryHrytsuk added this to the Engage milestone Jun 16, 2025
@YuryHrytsuk YuryHrytsuk self-assigned this Jun 16, 2025
@YuryHrytsuk YuryHrytsuk requested a review from mrnicegyu11 as a code owner June 16, 2025 07:23
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

necessary bureaucracy 🖊️ 📖 ✅

@YuryHrytsuk
Copy link
Collaborator Author

necessary bureaucracy 🖊️ 📖 ✅

It helped me already multiple times.

While adding new services, I tend to forget that we need to do many things to do it right (set multiple replicas, adding e2e tests, updating credentials page, etc) ✔️

@YuryHrytsuk YuryHrytsuk merged commit ec3e6b0 into ITISFoundation:main Jun 16, 2025
3 checks passed
@YuryHrytsuk YuryHrytsuk deleted the update-pr-template branch June 16, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants