Refactor: ops-traefik configuration (2nd attempt) #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oundation#979) * Introduce longhorn chart * Further longhorn configuration * Longhorn: further settings configuration * Fix longhorn configuration bugs Extra: introduce longhorn pv vales for portainer * Add comment for deletion longhorn * Further longhorn configuration * Add README.md for Longhorn wit FAQ * Update Longhorn readme * Update readme * Futher LH configuration * Update LH's Readme * Update Longhorn Readme * Improve LH's Readme * LH: Reduce reserved default disk space to 5% Since we use a dedicated disk for LH, we can go ahead with 5% * Use values to set Longhorn storage class * Update LH's Readme * LH Readme: add requirements reference * PR Review: bring back portainer s3 pv * LH: decrease portinaer volume size
mrnicegyu11
changed the title
YuryHrytsuk
reviewed
Jul 8, 2025
charts/simcore-charts/resource-usage-tracker/values.yaml.gotmpl
Outdated
Show resolved
Hide resolved
YuryHrytsuk
reviewed
Jul 8, 2025
YuryHrytsuk
reviewed
Jul 8, 2025
| configs: | ||
| - source: traefik_dynamic_config.yml | ||
| target: /etc/traefik/dynamic_conf.yml | ||
| env_file: | ||
| - .env |
There was a problem hiding this comment.
Question: does docker swarm requires .env file to be always present or it can be removed after being deployed?
Since in CI we always clean up files, .env will be removed after deploy
There was a problem hiding this comment.
Good point, I am 99% sure this is only needed at deploy time and can be removed, but I will double-check it
YuryHrytsuk
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Re-iteration of mrnicegyu11#1
Emerged as a needed refactoring to facilitate #1041 (comment)
Sets the traefik-config using env-vars instead of CLI arguments, avoids the need for per-deployment-target docker-compose files (except
osparc.local)Bonus:
REDIS_EXTERNAL_HOSTosparc.local/cert_domains.jsonTRACING_OPENTELEMETRY_COLLECTOR_SAMPLING_PERCENTAGEto 100 everywhereRelated issue/s
Related PR/s
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1482
Checklist