Skip to content

Graylog: update content pack (grock pattern) #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jul 16, 2025

What do these changes do?

  • Since the async logger went in (⚗️Introduce asynchronous logging facilities (🚨) osparc-simcore#8064) we cannot search for fields in Graylog (e.g. the trace id) because one of the GROK patterns were wrong. There were two symptoms I observed when searching for fields in Graylog:
    • Some fields could not be searched (e.g. the log_trace_id)
    • Some fields were parsed incorrectly (e.g. the log_span_id).
  • This PR fixes that.

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@bisgaard-itis bisgaard-itis self-assigned this Jul 16, 2025
@bisgaard-itis bisgaard-itis added this to the Engage milestone Jul 16, 2025
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@YuryHrytsuk
Copy link
Collaborator

@bisgaard-itis did you rewrite the whole file? I thought I could review on line basis but this seems like a new file with a few old lines preserved

@bisgaard-itis
Copy link
Contributor Author

@bisgaard-itis did you rewrite the whole file? I thought I could review on line basis but this seems like a new file with a few old lines preserved

The file is generated from Graylog with the help of @matusdrobuliak66 😄. So yes, the entire file is new.

@YuryHrytsuk
Copy link
Collaborator

YuryHrytsuk commented Jul 16, 2025

@bisgaard-itis could you update PR's decsription and link related PRs and issues? Also describe changes you did (bug fixes, new fields?) This is important for traceability. Otherwise, in 6 months we would stumble upon this PR and have no clue what's what.

Thanks!

@bisgaard-itis
Copy link
Contributor Author

@bisgaard-itis could you update PR's decsription and link related PRs and issues? Also describe changes you did (bug fixes, new fields?) This is important for traceability. Otherwise, in 6 months we would stumple upon this PR and have no clue what's what.

Thanks!

Done! Thanks

Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

Maybe linking tracing PR / Issue would also make sense (or whatever PR introduced log_trace_* fields) 🙏

@bisgaard-itis
Copy link
Contributor Author

Thanks 🙏

Maybe linking tracing PR / Issue would also make sense (or whatever PR introduced log_trace_* fields) 🙏

Done

@bisgaard-itis bisgaard-itis merged commit 1865d84 into main Jul 16, 2025
4 checks passed
@bisgaard-itis bisgaard-itis deleted the update-grok-pattern branch July 16, 2025 10:17
@YuryHrytsuk YuryHrytsuk changed the title update grok pattern Graylog: update content pack (grock pattern) Jul 17, 2025
bisgaard-itis added a commit that referenced this pull request Jul 17, 2025
bisgaard-itis added a commit that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants