-
Notifications
You must be signed in to change notification settings - Fork 6
Graylog: update content pack (grock pattern) #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@bisgaard-itis did you rewrite the whole file? I thought I could review on line basis but this seems like a new file with a few old lines preserved |
The file is generated from Graylog with the help of @matusdrobuliak66 😄. So yes, the entire file is new. |
@bisgaard-itis could you update PR's decsription and link related PRs and issues? Also describe changes you did (bug fixes, new fields?) This is important for traceability. Otherwise, in 6 months we would stumble upon this PR and have no clue what's what. Thanks! |
Done! Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏
Maybe linking tracing PR / Issue would also make sense (or whatever PR introduced log_trace_*
fields) 🙏
Done |
This reverts commit 1865d84.
What do these changes do?
log_trace_id
)log_span_id
).Related issue/s
Related PR/s
asyncio.Queue
s osparc-simcore#6857Checklist