-
Notifications
You must be signed in to change notification settings - Fork 6
Add fallback simcore traefik routes #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback simcore traefik routes #950
Conversation
Next progress shall be done during sprint that follows |
Traefik placeholder will be used to define low priority traeifk configuration that will kick in once main docker serviec is not heathy (its configuration is removed)
This shall be done in separate PR. First we introduce proper 503 status codes and then we sync about serving some content
Check first commit for explanations
Add fallback routes that will take effect once main services (e.g. webserver is not in `running` state). Once service is not in `running` state, its configuration is removed from traefik leading to 404. Related Issue(s): * ITISFoundation/osparc-ops-environments#218 Related PR(s): * ITISFoundation/osparc-ops-environments#950
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks a lot for this nice improvement.
Thanks also for the graphical schema, it took me some minutes to wrap my head around what is happening here, let's see if the traefik people maybe also respond to your issue that you filed there for allowEmptyServices
.
I guess for now, as you write in "How to test", this specifically services 503
for invalid URLs or in case of "unhealthyness" of either traefik or simcore services down the line. Is it planned to somehow connect this to a maintenance-page ("Apologies our services are down please check our statuspage for more" or so) or is it even possible using these traefik patterns?
Anyway, very cool!
traefik http service name should be `invitations` (not `webserver`). This is a typo (after copy pasting) Related PR(s): * Bug was introduced in ITISFoundation#950
traefik http service name should be `invitations` (not `webserver`). This is a typo (after copy pasting) Related PR(s): * Bug was introduced in #950
What do these changes do?
Read more in ITISFoundation/osparc-simcore#7899
Next steps
Serve custom html / json content to users if service is not in
running
state but keep 503 errors coming from arunning
(docker healthy) andready
(traefik lb healthy) servicesRelated issue/s
Related PR/s
Checklist
If exposed via traefik --> Not applicable since no new service is introduced