-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Here are some potential followups to #115:
-
Vertexwrapper (likeVerticesbut indicating it is a single vertex). -
to_vertexfunction as an interface for canonicalizing single vertex inputs, such as convertingQuotientVertexVertexto a plain vertex (which is currently handled byto_graph_index). -
get_graph_indexcould call out to new interface functionsget_graph_vertexorget_graph_edge, and maybe callto_vertexorto_edgefor vertex/edge canonicalization (see the point above proposingto_vertex). -
get_graph_indicescould call out to new interface functionsget_graph_verticesorget_graph_edges, which could callto_verticesorto_edgesfor vertex/edge collection canonicalization (such as wrappingQuotientVertexVerticesin aQuotientVertexSlice). - Reevaluate
parent_graph_indices, maybe find a better name or see if it can be removed. - Reevaluate
graph_index_list_to_graph_indexname/interface. Maybe it could be calledflatten_graph_index_list? - Define
isassigned(g::AbstractNamedGraph, I) = false(and write it in terms of associated interface functionsis_graph_index_assigned, etc. which would get overloaded by DataGraphs). - Define and
ispartitioned(g)trait function and use it indepartition/unpartition, see the discussion here:PartitionedGraphsextension forDataGraphsand interface overhaul. DataGraphs.jl#55 (comment). - Reassess what is output by
add/rem_vertex!,add/rem_edge!, since it is not consistent with the output of those functions in Graphs.jl. Maybe we want to introduce other stricter interfaces likeinsert_vertex!,delete_vertex!,set_vertex!,unset_vertex!, etc. (modeled after the Dictionaries.jl interface).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request