increasing presenter unit test coverage

Author: rdlebeau

app/presenters/hyrax/embargo_presenter.rb

@@ -20,7 +20,7 @@ def initialize(solr_document)
       @solr_document = solr_document
     end
 
-    def embargo_depostor
+    def embargo_depositor
       solr_document.fetch('depositor_ssim', []).first
     end
 

app/views/hyrax/embargoes/_list_active_embargoes.html.erb

@@ -14,7 +14,7 @@
     <tr>
       <td class="human-readable-type"><%= hrt %></td>
       <% if current_ability.admin? %>
-      <td class="depositor"><%= curation_concern.embargo_depostor %></td>
+      <td class="depositor"><%= curation_concern.embargo_depositor %></td>
       <% end %>
       <td class="title"><%= link_to curation_concern, edit_embargo_path(curation_concern) %></td>
       <td class="current-visibility"><%= visibility_badge(curation_concern.visibility) %></td>

app/views/hyrax/embargoes/_list_expired_active_embargoes.html.erb

@@ -35,7 +35,7 @@
           <td><%= render 'hyrax/batch_select/add_button', document: curation_concern %></td>
           <td class="human-readable-type"><%= hrt %></td>
           <% if current_ability.admin? %>
-            <td class="depositor"><%= curation_concern.embargo_depostor %></td>
+            <td class="depositor"><%= curation_concern.embargo_depositor %></td>
           <% end %>
           <td class="title"><%= link_to curation_concern, edit_embargo_path(curation_concern) %></td>
           <td class="current-visibility"><%= visibility_badge(curation_concern.visibility) %></td>

spec/models/concerns/hyrax/file_set/querying_spec.rb

@@ -1,12 +1,12 @@
 require 'rails_helper'
 
-class CurationConcernMock
+class QueryingFileSet
   include ::Hyrax::FileSet::Querying::ClassMethods
 end
 
 
 RSpec.describe Hyrax::FileSet::Querying::ClassMethods  do
-    subject { CurationConcernMock.new }
+  subject { QueryingFileSet.new }
 
   describe '#urnify' do
     it "returns urnification of string" do

spec/models/concerns/hyrax/with_events_spec.rb

@@ -0,0 +1,19 @@
+require 'rails_helper'
+
+class EventfulMock
+  include ::Hyrax::WithEvents
+
+end
+
+
+RSpec.describe Hyrax::WithEvents  do
+  subject { EventfulMock.new }
+
+  describe '#event_class' do
+    it "returns class name" do
+      expect(subject.event_class).to eq("EventfulMock")
+    end
+
+  end
+
+end

spec/models/hyrax/collection_type_participant_spec.rb

@@ -0,0 +1,65 @@
+require 'rails_helper'
+
+RSpec.describe Hyrax::CollectionTypeParticipant do
+
+  describe 'constants' do
+    it do
+      expect( ::Hyrax::CollectionTypeParticipant::MANAGE_ACCESS).to eq 'manage'
+      expect( ::Hyrax::CollectionTypeParticipant::CREATE_ACCESS).to eq 'create'
+      expect( ::Hyrax::CollectionTypeParticipant::GROUP_TYPE).to eq 'group'
+      expect( ::Hyrax::CollectionTypeParticipant::USER_TYPE).to eq 'user'
+    end
+  end
+
+  before do
+    subject.agent_id = "Agent ID"
+  end
+
+  describe '#manager?' do
+
+    it "returns true when access is MANAGE_ACCESS" do
+
+      subject.access = Hyrax::CollectionTypeParticipant::MANAGE_ACCESS
+      expect(subject.manager?).to eq true
+    end
+
+    it "returns false when access is not MANAGE_ACCESS" do
+
+      subject.access = Hyrax::CollectionTypeParticipant::CREATE_ACCESS
+      expect(subject.manager?).to eq false
+    end
+  end
+
+  describe '#creator?' do
+
+    it "returns true when access is CREATE_ACCESS" do
+
+      subject.access = Hyrax::CollectionTypeParticipant::CREATE_ACCESS
+      expect(subject.creator?).to eq true
+    end
+
+    it "returns false when access is not CREATE_ACCESS" do
+
+      subject.access = Hyrax::CollectionTypeParticipant::MANAGE_ACCESS
+      expect(subject.creator?).to eq false
+    end
+  end
+
+  describe '#label' do
+
+    it "returns agent_id when agent_type is not GROUP_TYPE" do
+
+      subject.agent_type = Hyrax::CollectionTypeParticipant::USER_TYPE
+      expect(subject.label).to eq "Agent ID"
+    end
+
+    it "returns agent_id when agent_type is GROUP_TYPE and agent_id not group name" do
+
+      subject.agent_type = Hyrax::CollectionTypeParticipant::GROUP_TYPE
+      expect(subject.label).to eq "Agent ID"
+    end
+
+    # TODO:  test other cases for agent_id
+  end
+
+  end

spec/models/hyrax/collection_type_spec.rb

@@ -0,0 +1,67 @@
+require 'rails_helper'
+
+RSpec.describe Hyrax::CollectionType do
+
+  describe 'constants' do
+    it do
+      expect( ::Hyrax::CollectionType::USER_COLLECTION_MACHINE_ID ).to eq 'user_collection'
+      expect( ::Hyrax::CollectionType::ADMIN_SET_MACHINE_ID ).to eq 'admin_set'
+    end
+  end
+
+  describe "#collections" do
+
+    # TODO: test positive case
+    it "returns empty array when gid has no value" do
+
+      allow(subject).to receive(:gid).and_return( nil )
+      expect(subject.collections).to eq []
+    end
+  end
+
+  describe "#collections?" do
+
+    it "returns true when collections has at least one item" do
+
+      allow(subject).to receive(:collections).and_return( %w[this that] )
+      expect(subject.collections?).to eq true
+    end
+
+    it "returns false when collections is empty" do
+
+      allow(subject).to receive(:collections).and_return( [] )
+      expect(subject.collections?).to eq false
+    end
+  end
+
+  describe '#admin_set?' do
+
+    it 'returns true when machine_id is ADMIN_SET_MACHINE_ID' do
+      subject.machine_id = Hyrax::CollectionType::ADMIN_SET_MACHINE_ID
+
+      expect( subject.admin_set? ).to eq true
+    end
+
+    it 'returns false when machine_id is USER_COLLECTION_MACHINE_ID' do
+      subject.machine_id = Hyrax::CollectionType::USER_COLLECTION_MACHINE_ID
+
+      expect( subject.admin_set? ).to eq false
+    end
+  end
+
+  describe '#user_collection?'
+
+    it 'returns false when machine_id is ADMIN_SET_MACHINE_ID' do
+      subject.machine_id = Hyrax::CollectionType::ADMIN_SET_MACHINE_ID
+
+      expect( subject.user_collection? ).to eq false
+    end
+
+    it 'returns true when machine_id is USER_COLLECTION_MACHINE_ID' do
+      subject.machine_id = Hyrax::CollectionType::USER_COLLECTION_MACHINE_ID
+
+      expect( subject.user_collection? ).to eq true
+    end
+  end
+
+

spec/presenters/hyrax/collection_presenter_spec.rb

@@ -3,9 +3,9 @@
 RSpec.describe Hyrax::CollectionPresenter do
   let(:user) { FactoryBot.create :user }
 
-  let(:user_key) { 'a_user_key' }
-  let(:attributes) do {} end
-
+  let(:attributes) do
+    { "bytes_lts" => '123' }
+  end
   let(:solr_document) { SolrDocument.new(attributes) }
   let(:current_ability) { instance_double(Ability, current_user: user ) }
   let(:request) { double(host: 'example.org', base_url: 'http://example.org') }
@@ -17,4 +17,93 @@
   it { is_expected.to delegate_method(:collection?).to(:solr_document) }
   it { is_expected.to delegate_method(:representative_id).to(:solr_document) }
   it { is_expected.to delegate_method(:to_s).to(:solr_document) }
+
+  it { is_expected.to delegate_method(:title).to(:solr_document) }
+  it { is_expected.to delegate_method(:description).to(:solr_document) }
+  it { is_expected.to delegate_method(:creator).to(:solr_document) }
+  it { is_expected.to delegate_method(:contributor).to(:solr_document) }
+  it { is_expected.to delegate_method(:subject).to(:solr_document) }
+  it { is_expected.to delegate_method(:publisher).to(:solr_document) }
+  it { is_expected.to delegate_method(:keyword).to(:solr_document) }
+  it { is_expected.to delegate_method(:contributor).to(:solr_document) }
+  it { is_expected.to delegate_method(:language).to(:solr_document) }
+  it { is_expected.to delegate_method(:embargo_release_date).to(:solr_document) }
+  it { is_expected.to delegate_method(:lease_expiration_date).to(:solr_document) }
+  it { is_expected.to delegate_method(:license).to(:solr_document) }
+  it { is_expected.to delegate_method(:date_created).to(:solr_document) }
+  it { is_expected.to delegate_method(:resource_type).to(:solr_document) }
+  it { is_expected.to delegate_method(:based_near).to(:solr_document) }
+  it { is_expected.to delegate_method(:related_url).to(:solr_document) }
+  it { is_expected.to delegate_method(:identifier).to(:solr_document) }
+  it { is_expected.to delegate_method(:thumbnail_path).to(:solr_document) }
+  it { is_expected.to delegate_method(:title_or_label).to(:solr_document) }
+  it { is_expected.to delegate_method(:collection_type_gid).to(:solr_document) }
+  it { is_expected.to delegate_method(:create_date).to(:solr_document) }
+  it { is_expected.to delegate_method(:modified_date).to(:solr_document) }
+  it { is_expected.to delegate_method(:visibility).to(:solr_document) }
+  it { is_expected.to delegate_method(:edit_groups).to(:solr_document) }
+  it { is_expected.to delegate_method(:edit_people).to(:solr_document) }
+
+  describe "#size" do
+    it "returns bytes as descriptive string" do
+      expect(subject.size).to eq "123 Bytes"
+    end
+  end
+
+  describe "#collection_type_badge" do
+    it "returns collection_type.title" do
+
+      allow(subject).to receive(:collection_type).and_return( double(title: 'Example of Grandiosity') )
+      expect(subject.collection_type_badge).to eq 'Example of Grandiosity'
+    end
+  end
+
+  describe "#total_parent_collections" do
+    it "returns parent_collections response numFound" do
+
+      allow(subject).to receive(:parent_collections).and_return( double( response: {"numFound" => 7} ) )
+      expect(subject.total_parent_collections).to eq 7
+    end
+  end
+
+  describe "#parent_collection_count" do
+    it "returns parent_collections documents size" do
+
+      allow(subject).to receive(:parent_collections).and_return( double(documents: ['1', '2', '3', '4', '5']) )
+      expect(subject.parent_collection_count).to eq 5
+    end
+  end
+
+
+
+  describe "#create_work_presenter" do
+    it "returns SelectTypeListPresenter" do
+      expect(subject.create_work_presenter).to be_kind_of Hyrax::SelectTypeListPresenter
+    end
+  end
+
+  describe "#draw_select_work_modal?" do
+
+    it "returns true" do
+      allow(subject).to receive(:create_many_work_types?).and_return(true)
+      expect(subject.draw_select_work_modal?).to eq true
+    end
+
+    it "returns false" do
+      allow(subject).to receive(:create_many_work_types?).and_return(false)
+      expect(subject.draw_select_work_modal?).to eq false
+    end
+  end
+
+  describe "#first_work_type" do
+    it "returns first string in list" do
+
+      allow(subject.create_work_presenter).to receive(:authorized_models).and_return(["Alpha", "Beta"])
+      expect(subject.first_work_type).to eq "Alpha"
+    end
+  end
+
+
+
+
 end

spec/presenters/hyrax/deep_blue_presenter_spec.rb

@@ -0,0 +1,40 @@
+require 'rails_helper'
+
+RSpec.describe Hyrax::DeepbluePresenter do
+  let(:user) { FactoryBot.create :user }
+  let(:attributes) do {} end
+  let(:solr_document) { SolrDocument.new(attributes) }
+  let(:current_ability) { instance_double(Ability, current_user: user ) }
+
+  subject { described_class.new(solr_document, current_ability) }
+
+  describe '#box_enabled?' do
+    it 'returns false' do
+      expect(subject.box_enabled?).to eq false
+    end
+  end
+
+  describe '#display_provenance_log_enabled?' do
+    it 'returns false' do
+      expect(subject.display_provenance_log_enabled?).to eq false
+    end
+  end
+
+  describe '#globus_download_enabled?' do
+    it 'returns false' do
+      expect(subject.globus_download_enabled?).to eq false
+    end
+  end
+
+  describe '#human_readable_type' do
+    it 'returns Work text' do
+      expect(subject.human_readable_type).to eq 'Work'
+    end
+  end
+
+  describe '#zip_download_enabled?' do
+    it 'returns false' do
+      expect(subject.zip_download_enabled?).to eq false
+    end
+  end
+end