Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command /API request for deploymentstatus does not return failed deployments #2830

Open
log1-c opened this issue Nov 7, 2023 · 1 comment
Labels
dev-call Issues and Pull Requests to be discussed at the Dev Call.

Comments

@log1-c
Copy link

log1-c commented Nov 7, 2023

Expected Behavior

Running icingacli director config deploymentstatus returns that there currently is a failed deplyoment and exits with EXIT_CODE!=0

Current Behavior

If you have a failed deployment (that possibly prevents reloading icinga or activating new config from a kickstart) the currently is no possibilty to check for said failed deployment (at least to my knowledge).

# icingacli director config deploymentstatus
# icingacli director config deploymentstatus
{
    "active_configuration": {
        "stage_name": "f41e4c2d-4fac-49a7-a80a-bdec4d693ecf",
        "config": "205ac9eb0368266572e467602d348ef597c1b801",
        "activity": "eca91ab4defd589c990c8fb87feaaf06521addce"
    }
}

image

Possible Solution

Make the check return above expected behavior or e.g. add a parameter --failed to check for failed deployments since the last active deployment.
Another possible solution could be monitoring automatic jobs for config deployment (if you have any). But this is not a viable way at the moment because you can't monitor/check only one jobs (see #2698 and #2740)

Your Environment

  • Director version (System - About): 1.11.0
  • Icinga Web 2 version and modules (System - About): 2.12
  • Icinga 2 version (icinga2 --version):2.14
  • Operating System and version:rhel8
  • Webserver, PHP versions: php7.2
@lippserd lippserd added the dev-call Issues and Pull Requests to be discussed at the Dev Call. label Oct 25, 2024
@lippserd
Copy link
Member

@log1-c thanks for the issue. Expected behavior sounds reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-call Issues and Pull Requests to be discussed at the Dev Call.
Projects
None yet
Development

No branches or pull requests

2 participants