SNI Mapping doesn't show multiple certificates

[offsides]

Describe the bug

I have an SNI mapping for a server with 3 certificates on a single IP. When I scan that IP, only one of the certificates shows up, with all 3 SNI names as the hostname (space separated list).

To Reproduce

Create an SNI mapping with 3 hostnames on 1 IP address and scan it. Look for the hostnames under Certificate Overview and Certificate Usage. Only 1 certificate shows up.

Expected behavior

I expected all 3 certificates to show up .

Screenshots

Your Environment

Include as many relevant details about the environment you experienced the problem in

• Icinga Web 2 version and modules (System - About): 2.12.2, icingadb 1.1.3, cube 1.3.3, doc 2.12.1, graphite 1.2.4, x509 1.3.2
• Web browser used: Firefox 135.0.1 (Win64)
• Icinga 2 version used (icinga2 --version): 2.14.5-1
• PHP version used (php --version): 8.2.25
• Server operating system and version: RHEL 9.6

[offsides]

Digging the code now that I had some time, it appears that this is a bug in library/X509/Hook/SniHook.php:

        foreach (Config::module('x509', 'sni') as $ip => $config) {
            foreach (array_filter(StringHelper::trimSplit($config->get('hostnames', []))) as $hostname) {
                $sni[$ip][$hostname] = $hostname;
            }
        }

In the above snipped, StringHelper::trimSplit is called without a delimiter, leading to it using the default delimiter of ',', whereas the SNI hostnames are actually delimited by "\r\n". Changing the trimSplit call to the following fixes it:

            foreach (array_filter(StringHelper::trimSplit($config->get('hostnames', []), "\r\n")) as $hostname) {

[nilmerg]

Hi,

leading to it using the default delimiter of ','

that is intended. It's the only supported delimiter and already suggested by the form when defining a new SNI map.

Implementation note

We should probably not use a textarea here but a ipl\Web\TermInput instead.