Skip to content
This repository has been archived by the owner on Dec 14, 2017. It is now read-only.

2.15 causes deadlocks/hangs under heavy load #160

Open
ErikEJ opened this issue Sep 8, 2017 · 10 comments
Open

2.15 causes deadlocks/hangs under heavy load #160

ErikEJ opened this issue Sep 8, 2017 · 10 comments

Comments

@ErikEJ
Copy link

ErikEJ commented Sep 8, 2017

It looks like this change causes thread deadlocks/hangs under heavy load (many requests (several 100s per second) running under ASP.NET) - why was the quick exit removed? dec7f5c#diff-5b2c5cc8b17ae721dd148a69c90508e6L136

WebAPI 2 under ASP.NET 4.6 in Azure App Service

@leastprivilege
Copy link
Member

Would this help?

#155

@ErikEJ
Copy link
Author

ErikEJ commented Sep 8, 2017

Sure, as it rolls back the behaviour to 2.14 implementation (which we had to roll back to)

@ErikEJ
Copy link
Author

ErikEJ commented Sep 8, 2017

@NicolaiPetri !

brockallen added a commit that referenced this issue Sep 8, 2017
@brockallen
Copy link
Member

We did an update that's supposed to deal with the deadlock in Microsoft's config loader. Please test again the myget version and let us know. https://www.myget.org/gallery/identity

Thanks

@ErikEJ
Copy link
Author

ErikEJ commented Sep 8, 2017

Is this recommended over / better performance wise than 2.14, that we have reverted to in production?

@leastprivilege
Copy link
Member

We hope this fixes the problem. But you need to test it.

@ErikEJ
Copy link
Author

ErikEJ commented Sep 8, 2017

Have you done any testing?

@leastprivilege
Copy link
Member

No - but we think this is the root cause.

@ErikEJ
Copy link
Author

ErikEJ commented Sep 8, 2017

I would be great if you were able to verify that - I will investigate possible test procedures

@strtdusty
Copy link

#155 seems like the correct fix here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants